Skip to content

fix(i18n): actually use i18n ctrl_key consistently - #2457

Merged
ghostdevv merged 1 commit into
mainfrom
serhalp/use-i18n-ctrl-key
Apr 12, 2026
Merged

fix(i18n): actually use i18n ctrl_key consistently#2457
ghostdevv merged 1 commit into
mainfrom
serhalp/use-i18n-ctrl-key

Conversation

@serhalp

Copy link
Copy Markdown
Member

🔗 Linked issue

N/A

🧭 Context

The i18n key already exists, we just weren't using it everywhere.

📚 Description

Replace hardcoded Ctrl with translations.

@vercel

vercelBot commented Apr 10, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
npmx.devReadyReadyPreview, CommentApr 10, 2026 1:06pm
2 Skipped Deployments
ProjectDeploymentActionsUpdated (UTC)
docs.npmx.devIgnoredIgnoredPreviewApr 10, 2026 1:06pm
npmx-lunariaIgnoredIgnoredApr 10, 2026 1:06pm

Request Review

@codecov

codecovBot commented Apr 10, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing linesPatch %Lines
app/composables/usePlatformModifierKey.ts75.00%0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@coderabbitai

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 5a3a129b-785d-438d-a4db-9b10a6e1ee4b

📥 Commits

Reviewing files that changed from the base of the PR and between eb2e6bb and 66254e0.

📒 Files selected for processing (1)
  • app/composables/usePlatformModifierKey.ts

📝 Walkthrough

Walkthrough

This change introduces internationalization support for platform-specific modifier key labels in the usePlatformModifierKey composable. The modification replaces hardcoded string values for the Ctrl key with localised labels retrieved through the useI18n() composable. The primaryModifierKeyLabel and commandPaletteShortcutLabel computed values now dynamically construct their strings using the localised Ctrl key label for non-Apple platforms, whilst preserving the existing Apple-specific symbol behaviour.

Possibly related PRs

Suggested reviewers

  • danielroe
  • ghostdevv
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check nameStatusExplanation
Description check✅ PassedThe pull request description clearly relates to the changeset: it explains the intent to replace hardcoded 'Ctrl' with i18n translations, which directly matches the file changes shown in the raw summary.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch serhalp/use-i18n-ctrl-key

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@serhalpserhalp added the needs review This PR is waiting for a review from a maintainer label Apr 10, 2026
@ghostdevv
ghostdevv added this pull request to the merge queueApr 12, 2026
@ghostdevvghostdevv removed the needs review This PR is waiting for a review from a maintainer label Apr 12, 2026
Merged via the queue into main with commit 287a3aeApr 12, 2026
24 checks passed
@ghostdevv
ghostdevv deleted the serhalp/use-i18n-ctrl-key branch April 12, 2026 02:12
@github-actionsgithub-actionsBot mentioned this pull request Apr 12, 2026
ayo-run pushed a commit to ayo-run/npmx.dev that referenced this pull request Aug 5, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@serhalp@ghostdevv