Skip to content

fix(i18n): format sparkline data label - #2519

Merged
graphieros merged 1 commit into
mainfrom
2518-sparkline-data-label-is-not-properly-internationalised
Apr 14, 2026
Merged

fix(i18n): format sparkline data label#2519
graphieros merged 1 commit into
mainfrom
2518-sparkline-data-label-is-not-properly-internationalised

Conversation

@graphieros

@graphierosgraphieros commented Apr 14, 2026

Copy link
Copy Markdown
Member

Resolves#2518

The downloads sparkline chart's data label was missing a number formatter.

@graphierosgraphieros linked an issue Apr 14, 2026 that may be closed by this pull request
@coderabbitai

coderabbitaiBot commented Apr 14, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: bd341494-eb32-4601-b3a7-3c3c7fa82cc7

📥 Commits

Reviewing files that changed from the base of the PR and between 4e8c727 and fe5c47b.

📒 Files selected for processing (1)
  • app/components/Package/WeeklyDownloadStats.vue

📝 Walkthrough

Summary by CodeRabbit

  • Bug Fixes
    • Enhanced number formatting in the weekly download statistics display to show more readable and properly formatted values in the chart.

Walkthrough

The PR adds number formatter initialization via useNumberFormatter() hook and integrates it into the sparkline's data label formatter configuration. This resolves improper internationalisation of the sparkline download chart's data label.

Changes

Cohort / File(s)Summary
Number Formatter Integration
app/components/Package/WeeklyDownloadStats.vue
Initialised numberFormatter composable and wired it into the sparkline's config.style.dataLabel.formatter to properly format data labels with locale-aware number formatting.

Suggested reviewers

  • danielroe
🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check nameStatusExplanation
Title check✅ PassedThe title 'fix(i18n): format sparkline data label' is directly related to the main change, which adds number formatting to the sparkline's data label for internationalisation support.
Description check✅ PassedThe description relates to the changeset by explaining that a number formatter was added to the sparkline data label for internationalisation, matching the actual code changes.
Linked Issues check✅ PassedThe pull request successfully addresses issue #2518 by initialising and implementing the numberFormatter in the sparkline's data label configuration.
Out of Scope Changes check✅ PassedAll code changes are scoped to adding the number formatter to the sparkline data label in the WeeklyDownloadStats component, directly addressing the linked issue.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 2518-sparkline-data-label-is-not-properly-internationalised

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@vercel

vercelBot commented Apr 14, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
npmx.devReadyReadyPreview, CommentApr 14, 2026 3:41pm
2 Skipped Deployments
ProjectDeploymentActionsUpdated (UTC)
docs.npmx.devIgnoredIgnoredApr 14, 2026 3:41pm
npmx-lunariaIgnoredIgnoredApr 14, 2026 3:41pm

Request Review

@codecov

codecovBot commented Apr 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@graphieros
graphieros added this pull request to the merge queueApr 14, 2026
Merged via the queue into main with commit ef819d1Apr 14, 2026
25 checks passed
@graphieros
graphieros deleted the 2518-sparkline-data-label-is-not-properly-internationalised branch April 14, 2026 16:14
@github-actionsgithub-actionsBot mentioned this pull request Apr 14, 2026
ayo-run pushed a commit to ayo-run/npmx.dev that referenced this pull request Aug 5, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sparkline data label is not properly internationalised

3 participants

@graphieros@43081j@alexdln