Skip to content

fix: persist zoom state in line charts - #2689

Merged
ghostdevv merged 2 commits into
mainfrom
tooltip-regression
May 8, 2026
Merged

fix: persist zoom state in line charts#2689
ghostdevv merged 2 commits into
mainfrom
tooltip-regression

Conversation

@graphieros

@graphierosgraphieros commented May 8, 2026

Copy link
Copy Markdown
Member

follow-up to #2688

This fixes the unwanted re-rendering of the zoom component in line charts for downloads when the chart config is dynamically updated.

Test:

  • display a downloads chart (modal, or compare page)
  • use the zoom
  • hover the chart: zoom does not reset

@vercel

vercelBot commented May 8, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
npmx.devReadyReadyPreview, CommentMay 8, 2026 3:33pm
2 Skipped Deployments
ProjectDeploymentActionsUpdated (UTC)
docs.npmx.devIgnoredIgnoredPreviewMay 8, 2026 3:33pm
npmx-lunariaIgnoredIgnoredMay 8, 2026 3:33pm

Request Review

@coderabbitai

coderabbitaiBot commented May 8, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)
  • release

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 4c4da8a0-c4f4-4355-a47c-34f6b8c4977d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

The TrendsChart.vue component now preserves zoom state across chart updates by enabling keepState: true in the VueUiXy chart's zoom configuration options.

Changes

Zoom State Persistence

Layer / File(s)Summary
Chart Zoom Configuration
app/components/Package/TrendsChart.vue
VueUiXy zoom options updated to add keepState: true alongside existing zoom settings (maxWidth, highlightColor, useResetSlot).

Suggested reviewers

  • userquin
  • gameroman
  • MatteoGabriele
🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check nameStatusExplanation
Title check✅ PassedThe title accurately describes the main change: enabling zoom state persistence in line charts through a configuration update.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Description check✅ PassedThe pull request description clearly explains the purpose of the change: fixing unwanted re-rendering of the zoom component by preserving zoom state.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch tooltip-regression

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@graphierosgraphieros changed the title fix: add missing config attr to keep zoom statefix: persist zoom state in line chartsMay 8, 2026
@codecov

codecovBot commented May 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@graphierosgraphieros added the needs review This PR is waiting for a review from a maintainer label May 8, 2026
@ghostdevv
ghostdevv added this pull request to the merge queueMay 8, 2026
Merged via the queue into main with commit f8cff4cMay 8, 2026
29 checks passed
@ghostdevv
ghostdevv deleted the tooltip-regression branch May 8, 2026 16:32
@github-actionsgithub-actionsBot mentioned this pull request May 8, 2026
@gameromangameroman removed the needs review This PR is waiting for a review from a maintainer label May 24, 2026
ayo-run pushed a commit to ayo-run/npmx.dev that referenced this pull request Aug 5, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@graphieros@ghostdevv@gameroman