Uh oh!
There was an error while loading. Please reload this page.
chore: upgrade vite-plus to 0.1.20 and fix surfaced a11y violations - #2697
Conversation
Upgrade vite-plus and related packages from 0.1.16 to 0.1.20 (latest stable), and fix the 14 WCAG AA color-contrast violations that the upgrade exposed in test/nuxt/a11y.spec.ts. The strongest candidate for the behavior change is upstream vitest-dev/vitest#10049 ("fix(browser): spread user server options into browser Vite server in project"), shipped in vitest@4.1.4. Before that fix, createBrowserServer silently dropped user server.* options, so the browser-mode Vite server didn't fully serve UnoCSS-generated CSS and axe defaulted to plain black-on-white. After it, styles render correctly and axe surfaces pre-existing contrast issues. vite-plus 0.1.16 bundles vitest 4.1.2 (without the fix); 0.1.20 bundles 4.1.5 (with it). The violations are real and pre-date this PR — the upgrade only stops masking them. Source-level a11y fixes: - LinkBase: disabled buttons drop opacity-50 + text-fg/bg-fg (3.69:1) for text-fg-muted / bg-fg-muted tokens (~8:1) and add aria-disabled. - DiffSidebarPanel + DiffMobileSidebarDrawer: stats and semver badges use text-{green,red,yellow,purple}-700 dark:text-{...}-400, matching the existing Alert.vue convention. - DiffSkipBlock: drop redundant opacity-50; text-fg-muted on bg-bg-muted already meets contrast. - DiffLine: line-number cell uses text-fg-subtle (5.5:1+) instead of opacity-50 over inherited text (3.69:1). - main.css: light-mode --accent default oklch(0.5 0.16 247.27) so text-accent on bg-fg/10 reaches ~5:1 (was 4.19); user-set --accent-color overrides remain unaffected.
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
📝 WalkthroughWalkthroughLight theme accent colours are refined from Oklch ChangesTheme Refinement and Component Styling
Suggested reviewers
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
e18e dependency analysisNo dependency warnings found. |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Uh oh!
There was an error while loading. Please reload this page.
🔗 Linked issue
🧭 Context
📚 Description
Upgrade vite-plus and related packages from 0.1.16 to 0.1.20 (latest stable), and fix the 14 WCAG AA color-contrast violations that the upgrade exposed in
test/nuxt/a11y.spec.ts.The strongest candidate for the behavior change is upstream vitest-dev/vitest#10049 ("fix(browser): spread user server options into browser Vite server in project"), shipped in
vitest@4.1.4.Before that fix, createBrowserServer silently dropped user
server.*options, so the browser-mode Vite server didn't fully serve UnoCSS-generated CSS and axe defaulted to plain black-on-white.After it, styles render correctly and axe surfaces pre-existing contrast issues. vite-plus 0.1.16 bundles vitest 4.1.2 (without the fix); 0.1.20 bundles 4.1.5 (with it).
The violations are real and pre-date this PR — the upgrade only stops masking them.
Source-level a11y fixes:
opacity-50 + text-fg/bg-fg (3.69:1)fortext-fg-muted / bg-fg-mutedtokens (~8:1) and add aria-disabled.text-{green,red,yellow,purple}-700 dark:text-{...}-400, matching the existingAlert.vueconvention.opacity-50; text-fg-mutedonbg-bg-mutedalready meets contrast.text-fg-subtle (5.5:1+)instead ofopacity-50over inherited text (3.69:1).oklch(0.5 0.16 247.27)so text-accent onbg-fg/10reaches ~5:1 (was 4.19); user-set --accent-color overrides remain unaffected.