Skip to content

fix(i18n): footer translations should actually be applied - #2711

Merged
ghostdevv merged 1 commit into
npmx-dev:mainfrom
BabyLy233:fix/footer-i18n
May 11, 2026
Merged

fix(i18n): footer translations should actually be applied#2711
ghostdevv merged 1 commit into
npmx-dev:mainfrom
BabyLy233:fix/footer-i18n

Conversation

@BabyLy233

Copy link
Copy Markdown
Contributor

🔗 Linked issue

resolves#2710

🧭 Context

make the AppFooter component display the correct i18n value

📚 Description

image After modification, the correct translation value of the current i18n can be displayed correctly.

@vercel

vercelBot commented May 11, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
npmx.devReadyReadyPreview, CommentMay 11, 2026 7:09am
2 Skipped Deployments
ProjectDeploymentActionsUpdated (UTC)
docs.npmx.devIgnoredIgnoredPreviewMay 11, 2026 7:09am
npmx-lunariaIgnoredIgnoredMay 11, 2026 7:09am

Request Review

@coderabbitai

coderabbitaiBot commented May 11, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The AppFooter component refactors footerSections from a static constant to a computed reactive property. This ensures footer section labels, derived from i18n t() calls, update reactively when the language locale changes rather than remaining fixed at initial render.

Changes

AppFooter i18n Reactivity

Layer / File(s)Summary
Computed Footer Section Labels
app/components/AppFooter.vue
footerSections is converted from a static const to a computed() value, enabling reactive updates to localised section labels when the i18n locale changes. The array structure and keyboard shortcuts handler remain unchanged.

Suggested reviewers

  • romansp
  • graphieros
🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check nameStatusExplanation
Description check✅ PassedThe description explains the i18n translation issue, references the linked issue #2710, and shows a screenshot demonstrating the fix.
Linked Issues check✅ PassedThe code change converts footerSections to a computed value, ensuring translations are dynamically resolved via the reactive system rather than statically evaluated, which directly addresses issue #2710's requirement to apply current i18n values.
Out of Scope Changes check✅ PassedThe changes are limited to making footerSections reactive in AppFooter.vue, which is directly scoped to resolving the i18n translation display issue in issue #2710.
Title check✅ PassedThe title accurately describes the main change: converting footer translations from static to reactive computed values to ensure i18n translations are properly applied.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov

codecovBot commented May 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@ghostdevvghostdevv changed the title fix(i18n): make the AppFooter component display the correct i18n valuefix(i18n): footer translations should actually be appliedMay 11, 2026
@ghostdevv
ghostdevv added this pull request to the merge queueMay 11, 2026
Merged via the queue into npmx-dev:main with commit 2eb8b91May 11, 2026
26 checks passed
@github-actionsgithub-actionsBot mentioned this pull request May 11, 2026
ayo-run pushed a commit to ayo-run/npmx.dev that referenced this pull request Aug 5, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Footer isn't being translated despite having translations

4 participants

@BabyLy233@WilcoSp@ghostdevv@gameroman