Uh oh!
There was an error while loading. Please reload this page.
fix(ui): improve layout of line charts - #2759
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
📝 WalkthroughWalkthroughThe PR upgrades the vue-data-ui charting library to version 3.19.8 and configures grid positioning alignment across chart components. Layout refinements in TrendsChart increase right padding for label spacing and adjust the pending-state overlay rectangle dimensions for better coverage during data transitions. ChangesChart grid positioning and layout refinements
Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
e18e dependency analysisNo dependency warnings found. |
Uh oh!
There was an error while loading. Please reload this page.
This update allows to use the full real estate of the chart area for line charts.
The previous implementation used
config.chart.grid.position: 'middle', which positions datapoints in the middle of x slots, resulting in empty space when there are only a few periods to show. This layout is designed to have lines and bars coexist on a same chart, but is not ideal when there is only line types.The
3.19.8patch fixes layout issues whenconfig.chart.grid.position: 'start', now allowing its usage, and preventing white space on the sides.This change was made to the following components: