Skip to content

fix: remove ambiguous community wording from replacement suggestions - #2875

Merged
gameroman merged 4 commits into
mainfrom
wording-warning
Jun 11, 2026
Merged

fix: remove ambiguous community wording from replacement suggestions#2875
gameroman merged 4 commits into
mainfrom
wording-warning

Conversation

@TheAlexLichter

Copy link
Copy Markdown
Contributor

🔗 Linked issue

None (simple change)

🧭 Context

"The community" feels quite ambiguous/unclear at the moment, and two links (leading to the same main site) in a single warning draw focus away from the important part.

📚 Description

This PR slightly changes the wording, removes the "community" part, uses passive voice and makes the statement les ambiguous.

@vercel

vercelBot commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
npmx.devReadyReadyPreview, CommentJun 10, 2026 10:02pm
2 Skipped Deployments
ProjectDeploymentActionsUpdated (UTC)
docs.npmx.devIgnoredIgnoredPreviewJun 10, 2026 10:02pm
npmx-lunariaIgnoredIgnoredJun 10, 2026 10:02pm

Request Review

@coderabbitai

coderabbitaiBot commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

Vue components for rendering package replacement types are corrected and simplified (simple/documented branches). i18n schema adds a new learn_more_above key. Locale files are updated to remove {community} placeholders and the community key from package.replacement across languages.

Changes

Replacement messaging refactor

Layer / File(s)Summary
i18n schema extension for learn_more_above
i18n/schema.json
Adds learn_more_above as a validated string property under package.replacement.
Vue component refactoring
app/components/Compare/ReplacementSuggestion.vue, app/components/Package/Replacement.vue
Fixes template closure in ReplacementSuggestion.vue for the simple branch; simplifies the documented branch in Replacement.vue to render $t('package.replacement.documented') instead of the prior i18n-t template containing module code and a community link.
Locale file updates for all languages
i18n/locales/* (multiple files)
Updates package.replacement blocks in locale files to remove {community} interpolation and the community key, rewrites or simplifies simple/documented messages to package‑neutral wording, and retains/adjusts learn_more and learn_more_above entries.

Possibly related PRs

  • npmx-dev/npmx.dev#2068: Touches the same replacement UI paths (ReplacementSuggestion.vue / Replacement.vue) and i18n selection for documented/simple rendering.

Suggested reviewers

  • ghostdevv
  • serhalp
  • alexdln
🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check nameStatusExplanation
Description check✅ PassedThe description adequately explains the motivation (removing ambiguous 'community' phrasing) and the approach (passive voice, reduced ambiguity), relating directly to the changeset of updated i18n translations and component rendering logic.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Title check✅ PassedThe title clearly and accurately describes the main change: removing ambiguous community-related wording from replacement suggestion messages across the codebase.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch wording-warning

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actionsBot commented Jun 7, 2026

Copy link
Copy Markdown

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

FileNote
i18n/locales/ar.jsonLocalization changed, will be marked as complete. 🔄️
i18n/locales/az-AZ.jsonLocalization changed, will be marked as complete. 🔄️
i18n/locales/bg-BG.jsonLocalization changed, will be marked as complete. 🔄️
i18n/locales/bn-IN.jsonLocalization changed, will be marked as complete. 🔄️
i18n/locales/cs-CZ.jsonLocalization changed, will be marked as complete. 🔄️
i18n/locales/de.jsonLocalization changed, will be marked as complete. 🔄️
i18n/locales/en.jsonSource changed, localizations will be marked as outdated.
i18n/locales/es.jsonLocalization changed, will be marked as complete. 🔄️
i18n/locales/fr-FR.jsonLocalization changed, will be marked as complete. 🔄️
i18n/locales/hi-IN.jsonLocalization changed, will be marked as complete. 🔄️
i18n/locales/hu-HU.jsonLocalization changed, will be marked as complete. 🔄️
i18n/locales/id-ID.jsonLocalization changed, will be marked as complete. 🔄️
i18n/locales/it-IT.jsonLocalization changed, will be marked as complete. 🔄️
i18n/locales/ja-JP.jsonLocalization changed, will be marked as complete. 🔄️
i18n/locales/kn-IN.jsonLocalization changed, will be marked as complete. 🔄️
i18n/locales/mr-IN.jsonLocalization changed, will be marked as complete. 🔄️
i18n/locales/nb-NO.jsonLocalization changed, will be marked as complete. 🔄️
i18n/locales/ne-NP.jsonLocalization changed, will be marked as complete. 🔄️
i18n/locales/nl.jsonLocalization changed, will be marked as complete. 🔄️
i18n/locales/pl-PL.jsonLocalization changed, will be marked as complete. 🔄️
i18n/locales/pt-BR.jsonLocalization changed, will be marked as complete. 🔄️
i18n/locales/pt-PT.jsonLocalization changed, will be marked as complete. 🔄️
i18n/locales/ro-RO.jsonLocalization changed, will be marked as complete. 🔄️
i18n/locales/ru-RU.jsonLocalization changed, will be marked as complete. 🔄️
i18n/locales/sr-Latn-RS.jsonLocalization changed, will be marked as complete. 🔄️
i18n/locales/ta-IN.jsonLocalization changed, will be marked as complete. 🔄️
i18n/locales/te-IN.jsonLocalization changed, will be marked as complete. 🔄️
i18n/locales/tr-TR.jsonLocalization changed, will be marked as complete. 🔄️
i18n/locales/uk-UA.jsonLocalization changed, will be marked as complete. 🔄️
i18n/locales/vi-VN.jsonLocalization changed, will be marked as complete. 🔄️
i18n/locales/zh-CN.jsonLocalization changed, will be marked as complete. 🔄️
i18n/locales/zh-TW.jsonLocalization changed, will be marked as complete. 🔄️
Warnings reference
IconDescription
🔄️The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@gameromangameroman added the e18e Relates to incorporating, linking to, or collaborating with https://e18e.dev label Jun 7, 2026
@codecov

codecovBot commented Jun 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@danielroedanielroe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems good to me, with the link doing the heavy lifting to point users to e18e

@danielroe
danielroe requested review from 43081j and patak-catJune 7, 2026 20:48
@gameroman
gameroman self-requested a review June 7, 2026 21:10
@ghostdevvghostdevv added the needs review This PR is waiting for a review from a maintainer label Jun 7, 2026

@patak-catpatak-cat left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also think this is a better way to word the warnings. Nice one!

@gameromangameroman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iirc, locales for other languages shouldn't be touched

@WilcoSpWilcoSp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For Dutch "documented" can be improved.

Comment threadi18n/locales/nl.json Outdated
Co-authored-by: Wilco <17604138+WilcoSp@users.noreply.github.com>
@ghostdevv

Copy link
Copy Markdown
Member

iirc, locales for other languages shouldn't be touched

+1 it's better to remove translations that need changes rather than use AI 🙏

@ghostdevvghostdevv changed the title fix(i18n): remove ambiguous community wordingfix: remove ambiguous community wording from replacement suggestionsJun 10, 2026
@ghostdevvghostdevv removed the needs review This PR is waiting for a review from a maintainer label Jun 10, 2026

@ghostdevvghostdevv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only other thing is that now there won't be any link to e18e on non-documented replacements edit: there already isn't

@ghostdevv
ghostdevv requested a review from gameromanJune 10, 2026 22:09
@gameroman
gameroman added this pull request to the merge queueJun 11, 2026
Merged via the queue into main with commit 1c48d0cJun 11, 2026
28 checks passed
@gameroman
gameroman deleted the wording-warning branch June 11, 2026 08:12
@github-actionsgithub-actionsBot mentioned this pull request Jun 11, 2026
ayo-run pushed a commit to ayo-run/npmx.dev that referenced this pull request Aug 5, 2026
…pmx-dev#2875)
Co-authored-by: Wilco <17604138+WilcoSp@users.noreply.github.com>
Co-authored-by: Willow (GHOST) <git@willow.sh>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

e18eRelates to incorporating, linking to, or collaborating with https://e18e.devi18nRelated to internationalization

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@TheAlexLichter@ghostdevv@patak-cat@43081j@WilcoSp@danielroe@gameroman