Skip to content

refactor: use built-in vue-data-ui composable - #2952

Merged
graphieros merged 1 commit into
mainfrom
2950-use-tooltip-position
Jun 23, 2026
Merged

refactor: use built-in vue-data-ui composable#2952
graphieros merged 1 commit into
mainfrom
2950-use-tooltip-position

Conversation

@graphieros

Copy link
Copy Markdown
Member

🔗 Linked issue

Resolves#2950

📚 Description

Replace the useChartTooltipPosition composable with the built-in useTooltipPosition from vue-data-ui.
No impact on functionality.

@graphierosgraphieros linked an issue Jun 23, 2026 that may be closed by this pull request
@vercel

vercelBot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
npmx.devReadyReadyPreview, CommentJun 23, 2026 1:58pm
2 Skipped Deployments
ProjectDeploymentActionsUpdated (UTC)
docs.npmx.devIgnoredIgnoredJun 23, 2026 1:58pm
npmx-lunariaIgnoredIgnoredJun 23, 2026 1:58pm

Request Review

@codecov

codecovBot commented Jun 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@coderabbitai

coderabbitaiBot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: c3e07462-a83f-46ac-9678-8239cab702c9

📥 Commits

Reviewing files that changed from the base of the PR and between a11045f and 4f98377.

📒 Files selected for processing (4)
  • app/components/Package/TimelineChart.vue
  • app/components/Package/TrendsChart.vue
  • app/composables/useChartTooltipPosition.ts
  • test/unit/app/composables/use-chart-tooltip-position.spec.ts
💤 Files with no reviewable changes (2)
  • test/unit/app/composables/use-chart-tooltip-position.spec.ts
  • app/composables/useChartTooltipPosition.ts

📝 Walkthrough

Summary by CodeRabbit

  • Refactor
    • Streamlined chart tooltip positioning logic across timeline and trends charts through internal composable consolidation.

Walkthrough

The custom useChartTooltipPosition composable and its unit test file are deleted. Both TimelineChart.vue and TrendsChart.vue replace the import and usage of that composable with useTooltipPosition from vue-data-ui/composables, keeping the same call signature useTooltipPosition(chartRef).

Changes

Tooltip position composable migration

Layer / File(s)Summary
Replace composable in chart components
app/components/Package/TimelineChart.vue, app/components/Package/TrendsChart.vue
Both components remove the import of useChartTooltipPosition and add useTooltipPosition from vue-data-ui/composables; tooltipPosition is initialised by calling useTooltipPosition(chartRef) in each component.
Delete local composable and tests
app/composables/useChartTooltipPosition.ts, test/unit/app/composables/use-chart-tooltip-position.spec.ts
The now-redundant local composable (mouse-position-based tooltip placement logic) and all 122 lines of its Vitest unit tests are removed.
🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check nameStatusExplanation
Title check✅ PassedThe title clearly and concisely summarises the main change: refactoring to use a built-in vue-data-ui composable instead of a custom one.
Description check✅ PassedThe description is directly related to the changeset, explaining the purpose of replacing the custom composable with the built-in one and noting no functional impact.
Linked Issues check✅ PassedThe PR fully meets all objectives from issue #2950: the custom useChartTooltipPosition composable and tests are removed, and both TimelineChart.vue and TrendsChart.vue are updated to use the built-in useTooltipPosition composable with correct import statements.
Out of Scope Changes check✅ PassedAll changes are directly scoped to the refactoring objective; no unrelated modifications are present in the pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 2950-use-tooltip-position

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@graphieros
graphieros requested a review from a teamJune 23, 2026 16:08
@graphierosgraphieros added the needs review This PR is waiting for a review from a maintainer label Jun 23, 2026
@graphieros
graphieros added this pull request to the merge queueJun 23, 2026
Merged via the queue into main with commit 92c4126Jun 23, 2026
28 checks passed
@graphieros
graphieros deleted the 2950-use-tooltip-position branch June 23, 2026 19:22
@github-actionsgithub-actionsBot mentioned this pull request Jun 23, 2026
BittuBarnwal7479 pushed a commit to BittuBarnwal7479/npmx.dev that referenced this pull request Jun 27, 2026
@gameromangameroman removed the needs review This PR is waiting for a review from a maintainer label Jun 29, 2026
ayo-run pushed a commit to ayo-run/npmx.dev that referenced this pull request Aug 5, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: use built-in vue-data-ui useTooltipPosition composable

2 participants

@graphieros@gameroman