Skip to content

fix: package code viewer overscroll - #3015

Closed
ghostdevv wants to merge 2 commits into
mainfrom
w/overscroll
Closed

fix: package code viewer overscroll#3015
ghostdevv wants to merge 2 commits into
mainfrom
w/overscroll

Conversation

@ghostdevv

@ghostdevvghostdevv commented Jul 7, 2026

Copy link
Copy Markdown
Member

🔗 Linked issue

🧭 Context

Fixes weird overscroll that is highlighted by #1977

📚 Description

Before:After:
imageimage

I tried to fix this too but I failed, it's such a delicate balance of styles here

Current:Ideal:
imageimage

@vercel

vercelBot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
docs.npmx.devReadyReadyPreviewAug 13, 2026 4:16am
npmx.devReadyReadyPreviewAug 13, 2026 4:16am
1 Skipped Deployment
ProjectDeploymentActionsUpdated (UTC)
npmx-lunariaIgnoredIgnoredAug 13, 2026 4:16am

Request Review

@coderabbitai

coderabbitaiBot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 1591f5b5-b7f7-4516-a842-730d65d657cd

📥 Commits

Reviewing files that changed from the base of the PR and between b582817 and cf8b3d7.

📒 Files selected for processing (1)
  • app/pages/package-code/[[org]]/[packageName]/v/[version]/[...filePath].vue
🚧 Files skipped from review as they are similar to previous changes (1)
  • app/pages/package-code/[[org]]/[packageName]/v/[version]/[...filePath].vue

📝 Walkthrough

Summary by CodeRabbit

  • Bug Fixes
    • Improved the desktop file-tree sidebar layout by ensuring it fills the full screen height.
    • Updated sidebar scrolling behaviour for a more consistent browsing experience.

Walkthrough

The desktop file-tree sidebar and its inner scroll container now use full viewport height with h-screen instead of calculated height sizing.

Changes

Sidebar Sizing Update

Layer / File(s)Summary
Sidebar height and scroll container
app/pages/package-code/[[org]]/[packageName]/v/[version]/[...filePath].vue
The desktop sidebar and inner scroll container now use h-screen instead of h-[calc(100vh-10.5rem)].

Mergeability Score:⚪ Minimal · up to cf8b3

This is a small localized adjustment to package code viewer scrolling behavior, with no identified merge-blocking risk remaining beyond normal checks and review.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check nameStatusExplanation
Title check✅ PassedThe title clearly identifies the main change: fixing overscroll in the package code viewer.
Description check✅ PassedThe description explains the overscroll issue and provides before-and-after examples related to the changeset.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch w/overscroll

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ghostdevv
ghostdevv marked this pull request as ready for review July 7, 2026 03:04
@codecov

codecovBot commented Jul 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@github-actionsgithub-actionsBot added the stale This has become stale and may be closed soon label Aug 6, 2026
@ghostdevvghostdevv removed the stale This has become stale and may be closed soon label Aug 13, 2026
@ghostdevv

Copy link
Copy Markdown
MemberAuthor

Not sure if this is still an issue, will re-open if I can reproduce

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@ghostdevv