Skip to content

fix: use valid rule names in oxlint disable comments - #3086

Merged
graphieros merged 1 commit into
npmx-dev:mainfrom
btea:fix/oxlint-disable-comments
Jul 28, 2026
Merged

fix: use valid rule names in oxlint disable comments#3086
graphieros merged 1 commit into
npmx-dev:mainfrom
btea:fix/oxlint-disable-comments

Conversation

@btea

@bteabtea commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

🔗 Linked issue

/

🧭 Context

📚 Description

The disable comments used oxlint's diagnostic display format eslint-plugin-unicorn(prefer-add-event-listener), which is not a valid rule name in oxlint-disable-next-line comments, so the warnings were not suppressed.

Use the plain rule name unicorn/prefer-add-event-listener instead.
https://oxc.rs/docs/guide/usage/linter/ignore-comments.html

@vercel

vercelBot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
npmx.devReadyReadyPreview, CommentJul 28, 2026 3:15am
2 Skipped Deployments
ProjectDeploymentActionsUpdated (UTC)
docs.npmx.devIgnoredIgnoredPreviewJul 28, 2026 3:15am
npmx-lunariaIgnoredIgnoredJul 28, 2026 3:15am

Request Review

@coderabbitai

coderabbitaiBot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

Lint suppression comments preceding two img.onload handlers are changed to oxlint directives. The image loading and promise resolution logic remains unchanged.

Changes

Lint directive updates

Layer / File(s)Summary
Update image handler directives
app/components/Brand/Customize.vue, app/utils/svg.ts
The existing img.onload handlers retain their behaviour while their unicorn/prefer-add-event-listener suppression comments use oxlint syntax.

Possibly related PRs

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check nameStatusExplanation
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Title check✅ PassedThe title clearly matches the main change: correcting oxlint disable comments to use valid rule names.
Description check✅ PassedThe description directly explains the lint comment fix and the rule-name change in the patch.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecovBot commented Jul 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@graphierosgraphieros changed the title fix(lint): use valid rule names in oxlint disable commentsfix: use valid rule names in oxlint disable commentsJul 28, 2026
@graphieros
graphieros added this pull request to the merge queueJul 28, 2026
Merged via the queue into npmx-dev:main with commit 33d3592Jul 28, 2026
25 of 26 checks passed
@github-actionsgithub-actionsBot mentioned this pull request Jul 28, 2026
@btea
btea deleted the fix/oxlint-disable-comments branch July 28, 2026 22:35
ayo-run pushed a commit to ayo-run/npmx.dev that referenced this pull request Aug 5, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@btea@gameroman@graphieros