feat: add deprecated marking to package timeline page by btea · Pull Request #3133 · npmx-dev/npmx.dev

btea · 2026-08-04T12:58:20Z

🔗 Linked issue

/

🧭 Context

📚 Description

vercel · 2026-08-04T12:58:25Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
npmx.dev	Ready	Preview	Aug 12, 2026 11:58pm

2 Skipped Deployments

Project	Deployment	Actions	Updated (UTC)
docs.npmx.dev	Ignored	Preview	Aug 12, 2026 11:58pm
npmx-lunaria	Ignored		Aug 12, 2026 11:58pm

github-actions · 2026-08-04T12:59:15Z

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File	Note
i18n/locales/en.json	Source changed, localizations will be marked as outdated.
i18n/locales/zh-CN.json	Localization changed, will be marked as complete. 🔄️
i18n/locales/zh-TW.json	Localization changed, will be marked as complete. 🔄️

Warnings reference

Icon	Description
🔄️	The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

gameroman · 2026-08-04T13:00:11Z

Also related to #2630

codecov · 2026-08-04T13:00:47Z

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...p/pages/package-timeline/[[org]]/[packageName].vue	0.00%	3 Missing and 1 partial ⚠️
app/components/Package/TimelineChart.vue	0.00%	1 Missing ⚠️

📢 Thoughts on this report? Let us know!

gameroman

Does it only show the latest version that is deprecated on timeline?

It seems to differ from the versions view

Screenshots

https://npmx-m0g6t0w58-npmx.vercel.app/package-timeline/websim/v/0.1.0

https://npmx-m0g6t0w58-npmx.vercel.app/package/websim/versions

coderabbitai · 2026-08-04T13:27:57Z

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

@coderabbitai resume to resume automatic reviews.
@coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

▶️ Resume reviews
🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 05d67ebe-1f67-46b1-aed3-5398110c3202

📥 Commits

Reviewing files that changed from the base of the PR and between 7aacc27 and c4ec2c3.

📒 Files selected for processing (1)

app/pages/package-timeline/[[org]]/[packageName].vue

🚧 Files skipped from review as they are similar to previous changes (1)

app/pages/package-timeline/[[org]]/[packageName].vue

📝 Walkthrough

Summary by CodeRabbit

New Features
- Package timeline entries now indicate when a version is deprecated, including versions without a predecessor.
- Timeline events distinguish success, warning and error states with green, amber and red markers and text.
- Timeline details display consistently for entries with sub-events or deprecation information.
- Deprecation information is available in English, Simplified Chinese and Traditional Chinese.
Documentation
- Added translations and schema support for the deprecated status label.

Walkthrough

The timeline API now returns deprecation messages and categorical sub-event states. The package timeline creates deprecation events for all deprecated versions. Charts render success, warning, and error states. Supported locales include the deprecated label.

Changes

Package timeline status states

Layer / File(s)	Summary
Define timeline status data `server/api/registry/timeline/[...pkg].get.ts`, `app/utils/charts.ts`	`TimelineVersion` now includes an optional `deprecated` field. `SubEvent` now uses `success`, `warn`, or `error` states instead of `positive`.
Generate timeline sub-events `app/pages/package-timeline/[[org]]/[packageName].vue`	The timeline creates error events for deprecated versions, including versions without a semver predecessor. Other version changes now use categorical states.
Render states and translations `app/components/Package/TimelineChart.vue`, `app/components/Package/TimelineChartXyTooltip.vue`, `i18n/schema.json`, `i18n/locales/en.json`, `i18n/locales/zh-CN.json`, `i18n/locales/zh-TW.json`	Charts classify and render success, warning, and error states. Locale files and the i18n schema define the deprecated label.

Sequence Diagram(s)

sequenceDiagram
participant PackageMetadata
participant TimelineAPI
participant PackageTimelinePage
participant TimelineCharts
participant I18nTranslations
PackageMetadata->>TimelineAPI: Provide deprecation metadata
TimelineAPI->>PackageTimelinePage: Return timeline versions and states
PackageTimelinePage->>I18nTranslations: Request deprecated label
I18nTranslations-->>PackageTimelinePage: Return translated label
PackageTimelinePage->>TimelineCharts: Render sub-events
TimelineCharts-->>PackageTimelinePage: Display green, amber, or red states

Possibly related PRs

npmx-dev/npmx.dev#2663: Updates the package timeline SubEvent model and rendering logic.
npmx-dev/npmx.dev#3121: Extends package timeline deprecation handling and categorical event states.
npmx-dev/npmx.dev#3142: Modifies the package timeline page and API endpoint.

Suggested reviewers:gameroman

Mergeability Score:⚪ Minimal · up to c4ec2

This change adds deprecated-package marking to the package timeline page without any identified merge-blocking risk; it is merge-ready after normal checks and review.

🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	❓ Inconclusive	The description identifies related work but contains no meaningful summary of the changes or their purpose.	Add a brief summary of the implementation, user impact, rationale, and relevant tests.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the main change: adding deprecated marking to the package timeline page.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

btea · 2026-08-04T13:32:50Z

@gameroman Thank you for providing the example; I hadn't considered this scenario before.

gameroman

Nice!

ghostdevv

I wonder if we should show the deprecation on the timeline graph itself too?

graphieros · 2026-08-12T04:13:51Z

I wonder if we should show the deprecation on the timeline graph itself too?

I think we should, since the chart can be exported, it needs to carry this information.
Changes I would recommend:

adding an icon to signal deprecation above related data points (and to avoid stacking possibly 3 icons above a data point, I would say if it is deprecated we only show the deprecation icon)
adding the deprecation information inside the tooltip
icon & tooltip info should be visible on all 3 charts
optional: adding a legend to explain what icons mean, 3 is already 'a lot'

These are not small changes, I recommend a separate issue. I think the present PR can be merged as is, then I can deal with the graph updates.

gameroman

I think instead of user provided deprecated message

We should show it just as "Deprecated version", for example

Or maybe like this

btea · 2026-08-12T09:15:20Z

@gameroman It has been adjusted.

gameroman

Looks nice

Timeline graph changes can be a separate PR 👍

graphieros · 2026-08-13T08:43:06Z

Timeline graph changes can be a separate PR 👍

Agreed, although it's just cosmetics, as the warning icon works well

feat: add deprecated marking to package timeline page
58a2fda

btea mentioned this pull request Aug 4, 2026
feat: time gap info to package timeline page #3121
Open

vercelBotdeployed to Preview – npmx.dev August 4, 2026 13:01 View deployment

gameroman reviewed Aug 4, 2026
View reviewed changes

fix: update
5a24cec

vercelBotdeployed to Preview – npmx.dev August 4, 2026 13:30 View deployment

gameroman approved these changes Aug 4, 2026
View reviewed changes

gameroman requested a review from a teamAugust 4, 2026 13:35

ghostdevv reviewed Aug 11, 2026
View reviewed changes

ghostdevv requested a review from 43081j August 11, 2026 21:57

gameroman self-requested a review August 12, 2026 08:25

gameroman requested changes Aug 12, 2026
View reviewed changes

btea added 2 commits August 12, 2026 17:05

fix: update
047c645

fix: update
e80edd3

vercelBotdeployed to Preview – npmx.dev August 12, 2026 09:09 View deployment

gameroman requested review from gameroman and ghostdevv August 12, 2026 09:27

gameroman added the needs review This PR is waiting for a review from a maintainer label Aug 12, 2026

43081j reviewed Aug 12, 2026
View reviewed changes

Comment threadapp/pages/package-timeline/[[org]]/[packageName].vue Outdated

fix: update
7aacc27

vercelBotdeployed to Preview – npmx.dev August 12, 2026 19:27 View deployment

43081j reviewed Aug 12, 2026
View reviewed changes

Comment threadapp/pages/package-timeline/[[org]]/[packageName].vue Outdated

fix: update
c4ec2c3

vercelBotdeployed to Preview – npmx.dev August 12, 2026 23:58 View deployment

43081j approved these changes Aug 13, 2026
View reviewed changes

gameroman approved these changes Aug 13, 2026
View reviewed changes

gameroman added this pull request to the merge queue Aug 13, 2026

Merged via the queue into npmx-dev:main with commit 9c6c3cfAug 13, 2026
24 checks passed

github-actionsBot mentioned this pull request Aug 13, 2026
chore: release v0.18.0 #3057
Merged

btea deleted the feat/timeline-deprecated branch August 13, 2026 08:57

graphieros mentioned this pull request Aug 13, 2026
feat: show error icon on the timeline chart #3175
Merged

Uh oh!

Uh oh!

Conversation

btea commented Aug 4, 2026

🔗 Linked issue

🧭 Context

📚 Description

Uh oh!

vercelBot commented Aug 4, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actionsBot commented Aug 4, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Lunaria Status Overview

Tracked Files

Uh oh!

gameroman commented Aug 4, 2026

Uh oh!

codecovBot commented Aug 4, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

gameroman left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

coderabbitaiBot commented Aug 4, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviews paused

Summary by CodeRabbit

Walkthrough

Changes

Sequence Diagram(s)

❌ Failed checks (1 inconclusive)

Uh oh!

btea commented Aug 4, 2026

Uh oh!

gameroman left a comment

Choose a reason for hiding this comment

Uh oh!

ghostdevv left a comment

Choose a reason for hiding this comment

Uh oh!

graphieros commented Aug 12, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gameroman left a comment

Choose a reason for hiding this comment

Uh oh!

btea commented Aug 12, 2026

Uh oh!

Uh oh!

Uh oh!

gameroman left a comment

Choose a reason for hiding this comment

Uh oh!

graphieros commented Aug 13, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

vercelBot commented Aug 4, 2026•
edited
Loading

github-actionsBot commented Aug 4, 2026•
edited
Loading

codecovBot commented Aug 4, 2026•
edited
Loading

gameroman left a comment •
edited
Loading

coderabbitaiBot commented Aug 4, 2026•
edited
Loading

graphieros commented Aug 12, 2026•
edited
Loading