Uh oh!
There was an error while loading. Please reload this page.
fix: remove tabindex=-1 for main skip link target - #3174
Conversation
Browsers already correctly set the “sequential focus navigation start point” and doing this tends to create a larger usability regression with regards to where the focus starts (i.e. clicking a focusable item within the element no longer sets that start point to that specific focusable, but on the containing element with tabindex=-1).
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe application removes ChangesMain content focus behaviour
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Uh oh!
There was an error while loading. Please reload this page.
🧭 Context
Browsers already correctly set the “sequential focus navigation starting point” and doing this tends to create a larger usability regression with regards to where the focus starts (i.e. clicking within the document doesn’t set the focus starting point to wherever that was, but rather to the outer element with
tabindex=-1).There is a counterpoint related to screen magnifiers, however, I find that the benefit that
tabindex=-1brings to those situations is overstated/inconsistent and not the reason whytabindex=-1was initially used as a hack in the first place.📚 Description
Just removes
tabindex=-1on the main skip link target.