Skip to content

feat: keyboard shortcut highlight on "?" press - #461

Closed
jellydeck wants to merge 13 commits into
npmx-dev:mainfrom
jellydeck:kbd-highlight
Closed

feat: keyboard shortcut highlight on "?" press#461
jellydeck wants to merge 13 commits into
npmx-dev:mainfrom
jellydeck:kbd-highlight

Conversation

@jellydeck

Copy link
Copy Markdown
Contributor

as discussed on #440

from help of @knowler

Co-Authored-By: Nathan Knowler <nathan@knowler.dev>
@vercel

vercelBot commented Jan 31, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
npmx.devReadyReadyPreview, CommentJan 31, 2026 0:01am
2 Skipped Deployments
ProjectDeploymentActionsUpdated (UTC)
docs.npmx.devIgnoredIgnoredPreviewJan 31, 2026 0:01am
npmx-lunariaIgnoredIgnoredJan 31, 2026 0:01am

Request Review

@jellydeckjellydeck changed the title feat: keyboard highlight on "?" pressfeat: keyboard shortcut highlight on "?" pressJan 31, 2026
@mikouaji

Copy link
Copy Markdown
Contributor

Great work!
You could update the comment in app.vue:L38 so it describes both behaviours

@danielroe

Copy link
Copy Markdown
Member

what do you think about #440 (comment) ?

jellydeckand others added 3 commits January 31, 2026 15:41
Co-Authored-By: Jens Rømer Hesselbjerg <26376491+jhroemer@users.noreply.github.com>
@jellydeck

Copy link
Copy Markdown
ContributorAuthor

what do you think about #440 (comment) ?

9492de5
key release removes data-attribute, also added @jhroemer as co-author :)

Comment threadapp/app.vue Outdated
jellydeckand others added 2 commits January 31, 2026 17:23
Co-authored-by: Robin <robin.kehl@singular-it.de>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@jellydeck@mikouaji@danielroe@OrbisK