Skip to content

chore: enable noUnusedLocals in tsconfig - #603

Merged
danielroe merged 3 commits into
npmx-dev:mainfrom
9romise:chore/no-unused
Feb 1, 2026
Merged

chore: enable noUnusedLocals in tsconfig#603
danielroe merged 3 commits into
npmx-dev:mainfrom
9romise:chore/no-unused

Conversation

@9romise

@9romise9romise commented Feb 1, 2026

Copy link
Copy Markdown
Member

No description provided.

@vercel

vercelBot commented Feb 1, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
npmx.devReadyReadyPreview, CommentFeb 1, 2026 4:15am
2 Skipped Deployments
ProjectDeploymentActionsUpdated (UTC)
docs.npmx.devIgnoredIgnoredPreviewFeb 1, 2026 4:15am
npmx-lunariaIgnoredIgnoredFeb 1, 2026 4:15am

Request Review

@serhalp

serhalp commented Feb 1, 2026

Copy link
Copy Markdown
Member

since the project uses the experimental oxlint, I wonder if we should ideally just be enabling more oxlint rules? e.g. the no-unused-... ones here: https://oxc.rs/docs/guide/usage/linter/rules.html 🤔

9romise
9romise commented Feb 1, 2026
View reviewed changes
Comment threadapp/components/ConnectorModal.vue

@9romise9romiseFeb 1, 2026

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow up to #540

@9romise

9romise commented Feb 1, 2026

Copy link
Copy Markdown
MemberAuthor

The no-unused-.. rules are categorized under correctness, which we've already set to error in the project, but I'm not seeing any complaints from it. I suspect it might be related to Vue? 🤔

9romise
9romise commented Feb 1, 2026
View reviewed changes
Comment thread.oxlintrc.json
@@ -1,5 +1,5 @@
{
"$schema": "./node_modules/oxlint/configuration_schema.json",
"$schema": "https://unpkg.com/oxlint/configuration_schema.json",

@9romise9romiseFeb 1, 2026

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are using vite-plus now, we can't read the file from this path.

@serhalp

serhalp commented Feb 1, 2026

Copy link
Copy Markdown
Member

The no-unused-.. rules are categorized under correctness, which we've already set to error in the project, but I'm not seeing any complaints from it. I suspect it might be related to Vue? 🤔

Good catch @9romise! I found it: oxc-project/oxc#11440. Those rules aren't yet implemented in the oxlint vue plugin!

@danielroe
danielroe added this pull request to the merge queueFeb 1, 2026
Merged via the queue into npmx-dev:main with commit 5c7222aFeb 1, 2026
13 checks passed
@9romise
9romise deleted the chore/no-unused branch February 1, 2026 08:01
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danielroedanielroedanielroe approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@9romise@serhalp@danielroe