Skip to content

feat: package page right sidebar scroll - #805

Merged
danielroe merged 4 commits into
npmx-dev:mainfrom
onebyte8bits:feature/package-rigntbar-scroll
Feb 4, 2026
Merged

feat: package page right sidebar scroll#805
danielroe merged 4 commits into
npmx-dev:mainfrom
onebyte8bits:feature/package-rigntbar-scroll

Conversation

@onebyte8bits

@onebyte8bitsonebyte8bits commented Feb 3, 2026

Copy link
Copy Markdown
Contributor

Fixes: #598


The sidebar section of the package details page is now scrollable.

@vercel

vercelBot commented Feb 3, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
npmx.devReadyReadyPreview, CommentFeb 4, 2026 10:19am
2 Skipped Deployments
ProjectDeploymentActionsUpdated (UTC)
docs.npmx.devIgnoredIgnoredPreviewFeb 4, 2026 10:19am
npmx-lunariaIgnoredIgnoredFeb 4, 2026 10:19am

Request Review

@wojtekmaj

This comment was marked as outdated.

@wojtekmaj

Copy link
Copy Markdown
Contributor

@onebyte8bits Please make sure to rebase the PR so that the latest changes to CI pipeline could be applied, making your PR mergable again. Thanks!

@onebyte8bits
onebyte8bitsforce-pushed the feature/package-rigntbar-scroll branch from d1c809a to dab1d8eCompareFebruary 3, 2026 10:37
Comment threadapp/pages/package/[...package].vue Outdated

@media (min-width: 1280px) {
.sidebar-scroll {
max-height: calc(100dvh - 6rem);

@alexdlnalexdlnFeb 3, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image (In the screenshot on the right there is a small empty black zone under the sidebar panel)

imo It's better to make something like a global variable --header-height: 3.75rem, use it as the height of the header, and calculate the dimensions dynamically from it here.

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image here?

@coderabbitai

coderabbitaiBot commented Feb 3, 2026

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

The package page component's sidebar was refactored to replace an overflow-hidden wrapper with a new .sidebar-scroll element that allows independent vertical scrolling. Template and stylesheet changes add responsive max-height constraints, custom scrollbar styling for desktop viewports, and behaviour to hide the scrollbar by default and reveal it on hover or focus. Layout and public interfaces remain unchanged.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check nameStatusExplanation
Description check✅ PassedThe pull request description directly references the linked issue (#598) and accurately describes the change made: enabling independent scrolling on the sidebar.
Linked Issues check✅ PassedThe pull request implements independent sidebar scrolling by introducing a scrollable wrapper with vertical scroll capability, directly addressing issue #598's requirement for sidebar scrollability.
Out of Scope Changes check✅ PassedAll changes are scoped to the package details page sidebar scrolling functionality. No unrelated modifications are present outside the linked issue's requirements.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Important

Action Needed: IP Allowlist Update

If your organization protects your Git platform with IP whitelisting, please add the new CodeRabbit IP address to your allowlist:

  • 136.113.208.247/32 (new)
  • 34.170.211.100/32
  • 35.222.179.152/32

Reviews will stop working after February 8, 2026 if the new IP is not added to your allowlist.


Comment @coderabbitai help to get the list of available commands and usage tips.

@onebyte8bits

Copy link
Copy Markdown
ContributorAuthor

@onebyte8bits Please make sure to rebase the PR so that the latest changes to CI pipeline could be applied, making your PR mergable again. Thanks!

done

@codecov

codecovBot commented Feb 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@danielroe
danielroe added this pull request to the merge queueFeb 4, 2026
Merged via the queue into npmx-dev:main with commit e86a550Feb 4, 2026
16 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't scroll the sidebar until the bottom of the sidebar matches bottom of page

4 participants

@onebyte8bits@wojtekmaj@danielroe@alexdln