Skip to content

test: reorganise npm unit tests - #876

Merged
danielroe merged 1 commit into
mainfrom
jg/npm-units
Feb 3, 2026
Merged

test: reorganise npm unit tests#876
danielroe merged 1 commit into
mainfrom
jg/npm-units

Conversation

@43081j

Copy link
Copy Markdown
Contributor

Leftovers from when I moved the utils around.

Leftovers from when I moved the utils around.
@vercel

vercelBot commented Feb 3, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
npmx.devReadyReadyPreview, CommentFeb 3, 2026 8:32pm
2 Skipped Deployments
ProjectDeploymentActionsUpdated (UTC)
docs.npmx.devIgnoredIgnoredPreviewFeb 3, 2026 8:32pm
npmx-lunariaIgnoredIgnoredFeb 3, 2026 8:32pm

Request Review

@codecov

codecovBot commented Feb 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@coderabbitai

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

This pull request reorganises unit tests for npm utilities. The test file test/unit/app/utils/npm.spec.ts is removed, with its test contents redistributed: buildScopeTeam tests are moved to a new file test/unit/app/utils/npm/common.spec.ts, whilst getSpdxLicenseUrl tests are relocated to test/unit/shared/utils/spdx.spec.ts. The spdx test file receives expanded coverage with additional license identifiers and edge cases. No runtime code changes are introduced.

Possibly related PRs

Suggested reviewers

  • danielroe
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check nameStatusExplanation
Description check✅ PassedThe pull request description accurately describes the changeset as reorganising unit tests and cleaning up leftovers from moving utilities.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch jg/npm-units

Comment @coderabbitai help to get the list of available commands and usage tips.

@danielroe
danielroe added this pull request to the merge queueFeb 3, 2026
Merged via the queue into main with commit b569b70Feb 3, 2026
17 checks passed
@danielroe
danielroe deleted the jg/npm-units branch February 3, 2026 21:22
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@43081j@danielroe