Skip to content

fix: display tooltips on focus for install size + create command - #919

Merged
danielroe merged 2 commits into
mainfrom
fix/tooltip-display
Feb 4, 2026
Merged

fix: display tooltips on focus for install size + create command#919
danielroe merged 2 commits into
mainfrom
fix/tooltip-display

Conversation

@danielroe

Copy link
Copy Markdown
Member

Previously these were not keyboard/tap accessible

SCR-20260204-jiuwSCR-20260204-jiwt

@vercel

vercelBot commented Feb 4, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
npmx.devReadyReadyPreview, CommentFeb 4, 2026 11:00am
2 Skipped Deployments
ProjectDeploymentActionsUpdated (UTC)
docs.npmx.devIgnoredIgnoredPreviewFeb 4, 2026 11:00am
npmx-lunariaIgnoredIgnoredFeb 4, 2026 11:00am

Request Review

@codecov

codecovBot commented Feb 4, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Files with missing linesPatch %Lines
app/components/Terminal/Install.vue33.33%1 Missing and 1 partial ⚠️
app/pages/package/[...package].vue0.00%0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@coderabbitai

coderabbitaiBot commented Feb 4, 2026

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

This pull request refactors tooltip and accessibility patterns in two components. In app/components/Terminal/Install.vue the TooltipApp wrapper is moved to surround the entire NuxtLink; the information icon and screen-reader text are moved inside the link and class assignments are consolidated. In app/pages/package/[...package].vue the information icon used with TooltipApp is wrapped in a focusable span (tabindex="0") with cursor and focus-visible styling to enable keyboard focus. No data-flow or retrieval logic was changed.

Possibly related PRs

  • npmx-dev/npmx.dev PR 883: Modifies tooltip usage in the same components, adjusting DOM structure around information icons and links and replacing title attributes with TooltipApp.
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check nameStatusExplanation
Description check✅ PassedThe description clearly relates to the changeset, indicating that tooltips were previously not keyboard/tap accessible and the changes address this accessibility issue.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/tooltip-display

Comment @coderabbitai help to get the list of available commands and usage tips.

@jellydeckjellydeck left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

outline width adjustments

Comment threadapp/components/Terminal/Install.vue Outdated
Comment threadapp/pages/package/[...package].vue Outdated
@danielroe
danielroe merged commit 191510b into mainFeb 4, 2026
18 of 19 checks passed
@danielroe
danielroe deleted the fix/tooltip-display branch February 4, 2026 11:10
@coderabbitaicoderabbitaiBot mentioned this pull request Mar 13, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@danielroe@jellydeck