Skip to content

chore: consistent back button across pages - #936

Merged
danielroe merged 1 commit into
npmx-dev:mainfrom
iiio2:chore/consistent-back-button
Feb 4, 2026
Merged

chore: consistent back button across pages#936
danielroe merged 1 commit into
npmx-dev:mainfrom
iiio2:chore/consistent-back-button

Conversation

@iiio2

@iiio2iiio2 commented Feb 4, 2026

Copy link
Copy Markdown
Contributor

resolves#918

page-onepage-twopage-three

@vercel

vercelBot commented Feb 4, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
npmx.devReadyReadyPreview, CommentFeb 4, 2026 1:21pm
2 Skipped Deployments
ProjectDeploymentActionsUpdated (UTC)
docs.npmx.devIgnoredIgnoredPreviewFeb 4, 2026 1:21pm
npmx-lunariaIgnoredIgnoredFeb 4, 2026 1:21pm

Request Review

@codecov

codecovBot commented Feb 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@coderabbitai

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

Both about.vue and compare.vue pages have been updated to include back navigation buttons within their headers using the useRouter composable. The back buttons trigger router.back() on click. In about.vue, the back button replaces a footer NuxtLink to the home page, whilst in compare.vue, the back button is integrated into a new flexible header layout. Both implementations include locale-aware labelling on larger screens and navigational iconography.

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Linked Issues check⚠️ WarningThe PR adds consistent back buttons to about.vue and compare.vue pages, but does not address the main objective of handling the collapsed logo/homepage navigation on smaller viewports (~640px).Implement the suggested solution to separate the search icon from the logo and ensure the logo persistently returns to the homepage across all viewports, particularly on mobile devices.
✅ Passed checks (2 passed)
Check nameStatusExplanation
Description check✅ PassedThe PR description references issue #918 with supporting screenshots, directly relating to the changeset's navigation improvements.
Out of Scope Changes check✅ PassedThe changes are focused solely on adding back buttons to two pages, which is directly scoped to the linked issue's consistency concerns.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@danielroe
danielroe added this pull request to the merge queueFeb 4, 2026
Merged via the queue into npmx-dev:main with commit 38cbfe0Feb 4, 2026
16 checks passed
@iiio2

iiio2 commented Feb 4, 2026

Copy link
Copy Markdown
ContributorAuthor

Thanks.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inconsitent ways to return to homepage

2 participants

@iiio2@danielroe