Skip to content

fix(cli): cli windows compat - #942

Merged
danielroe merged 3 commits into
npmx-dev:mainfrom
RYGRIT:fix/cli-windows-compat
Feb 4, 2026
Merged

fix(cli): cli windows compat#942
danielroe merged 3 commits into
npmx-dev:mainfrom
RYGRIT:fix/cli-windows-compat

Conversation

@RYGRIT

Copy link
Copy Markdown
Contributor

I found that the connector is not working properly on Windows.
The npmUser function here keeps returning undefined.

npmUser=awaitgetNpmUser()

@vercel

vercelBot commented Feb 4, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
npmx.devReadyReadyPreview, CommentFeb 4, 2026 2:26pm
2 Skipped Deployments
ProjectDeploymentActionsUpdated (UTC)
docs.npmx.devIgnoredIgnoredPreviewFeb 4, 2026 2:26pm
npmx-lunariaIgnoredIgnoredFeb 4, 2026 2:26pm

Request Review

@codecov

codecovBot commented Feb 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@coderabbitai

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

The npm client implementation is modified to enable shell execution for npm invocations on Windows platforms whilst maintaining the existing behaviour on non-Windows systems. The changes set the shell configuration option to true when running on Windows and false otherwise. These modifications are applied in two locations where npm is executed: during standard npm invocations and during package initialisation operations. The adjustment accommodates platform-specific requirements for command invocation on Windows systems.

🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check nameStatusExplanation
Description check✅ PassedThe description clearly identifies a Windows-specific issue with the npmUser function returning undefined and references the problematic location, which aligns with the changeset's focus on enabling shell execution for npm on Windows.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Important

Action Needed: IP Allowlist Update

If your organization protects your Git platform with IP whitelisting, please add the new CodeRabbit IP address to your allowlist:

  • 136.113.208.247/32 (new)
  • 34.170.211.100/32
  • 35.222.179.152/32

Reviews will stop working after February 8, 2026 if the new IP is not added to your allowlist.


Comment @coderabbitai help to get the list of available commands and usage tips.

@danielroe
danielroe added this pull request to the merge queueFeb 4, 2026
Merged via the queue into npmx-dev:main with commit 58da157Feb 4, 2026
15 checks passed
@RYGRIT
RYGRIT deleted the fix/cli-windows-compat branch February 6, 2026 00:12
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@RYGRIT@danielroe