Skip to content

fix: deduplicate when dependencies === transitive dependencies - #976

Merged
danielroe merged 2 commits into
npmx-dev:mainfrom
gameroman:no-deps-no-duplicate
Feb 5, 2026
Merged

fix: deduplicate when dependencies === transitive dependencies#976
danielroe merged 2 commits into
npmx-dev:mainfrom
gameroman:no-deps-no-duplicate

Conversation

@gameroman

@gameromangameroman commented Feb 5, 2026

Copy link
Copy Markdown
Member

Before

image{D7F66734-DECA-457E-86D0-DE5DEC93432F}

After

image{3A1D5502-7EDF-49F3-87CE-E38CA7F542B9}

@vercel

vercelBot commented Feb 5, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
npmx.devReadyReadyPreview, CommentFeb 5, 2026 0:17am
2 Skipped Deployments
ProjectDeploymentActionsUpdated (UTC)
docs.npmx.devIgnoredIgnoredPreviewFeb 5, 2026 0:17am
npmx-lunariaIgnoredIgnoredFeb 5, 2026 0:17am

Request Review

@codecov

codecovBot commented Feb 5, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing linesPatch %Lines
app/pages/package/[...package].vue0.00%10 Missing and 2 partials ⚠️

📢 Thoughts on this report? Let us know!

@coderabbitai

coderabbitaiBot commented Feb 5, 2026

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

The package page Vue component was updated so the separator between direct and total transitive dependencies and the blocks that show total transitive dependencies and install size are each rendered only when getDependencyCount(displayVersion) indicates dependencies exist. The total-transitive-deps block (spinner, total count or dash) and the install-size block (spinner, bytes or dash) were moved inside conditionals gated by the same dependency-count check. No computation or loading-state logic for totalDepsCount or install-size was changed. (≈46 words)

Possibly related PRs

Suggested reviewers

  • danielroe
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check nameStatusExplanation
Description check✅ PassedThe PR description consists of before/after screenshots demonstrating the visual changes to the dependencies and install size display.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@danielroedanielroe changed the title Don't show same info twice when 0 dependenciesfix: deduplicate when dependencies === transitive dependenciesFeb 5, 2026

@danielroedanielroe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the logic here should be that if dependencies === transitive dependencies, we only show one number

(rather than being about having zero dependencies)

@gameroman

Copy link
Copy Markdown
MemberAuthor

Yeah, makes sense I guess, will do so when I get home

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Comment threadapp/pages/package/[...package].vue Outdated
@danielroe
danielroe added this pull request to the merge queueFeb 5, 2026
Merged via the queue into npmx-dev:main with commit ca38eacFeb 5, 2026
16 of 17 checks passed
@gameroman
gameroman deleted the no-deps-no-duplicate branch February 6, 2026 22:09
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@gameroman@danielroe