Skip to content
This repository was archived by the owner on Feb 21, 2026. It is now read-only.

Use different data source for Pandas to GEOJson example - #28

Merged
captainsafia merged 2 commits into
nteract:masterfrom
programatt:FixExample
Jul 29, 2020
Merged

Use different data source for Pandas to GEOJson example#28
captainsafia merged 2 commits into
nteract:masterfrom
programatt:FixExample

Conversation

@programatt

Copy link
Copy Markdown
Contributor

The original datasource is no longer available. Switch to the correct data source (311 calls), and modify the dataframe to use the correct column names. NOTE: For me, I get no syntax errors when I run the notebook in nteract desktop, however, I don't get any columns to show up. Just a blank map. I'm not familiar with how it's supposed to work.

@review-notebook-app

Copy link
Copy Markdown

Check out this pull request on ReviewNB

Review Jupyter notebook visual diffs & provide feedback on notebooks.


Powered by ReviewNB

@MSealMSeal left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

"nbformat_minor": 0
}
"nbformat": 4,
"nbformat_minor": 0

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@captainsafia Are we not saving notebook files as 4.4 version when persisting? The format is clearly 4.4 despite the 4.0 indicator here. Should I create a separate issue for that?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MSeal Yes -- we preserve the minor format version from the original document which is why we get into this weird scenario.

I think this is a bug in commutable and not intentional behavior.

@captainsafiacaptainsafia left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I've gone as far as figuring out that the map doesn't render because the GeoJSON is malformed though I can't seem to figure out what part of it is....

@captainsafia

Copy link
Copy Markdown
Member

Merging this. I created a separate issue to resolve the underlying issue.

@captainsafia
captainsafia merged commit cd7bee8 into nteract:masterJul 29, 2020
@programatt
programatt deleted the FixExample branch August 3, 2020 01:29
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@programatt@captainsafia@MSeal