Uh oh!
There was an error while loading. Please reload this page.
Add patches for cross-compilation - #16
Merged
Merged
Conversation
Cherry-picked from mesonbuild@8d7ffe6
If need_exe_wrapper() is called while figuring out the language compiler, the MachineInfo isn't complete yet, so machine_info_can_run() would return False despite not cross compiling. Make sure this fails loudly. Squash of the following cherry-picked commits: - mesonbuild@df833b0 - mesonbuild@c108d5b - mesonbuild@eba9e7e
rgommers
approved these changes
Aug 6, 2024
rgommers
left a comment
Member
There was a problem hiding this comment.
Thanks @h-vetinari!
This LGTM and CI at numpy/numpy#27118 is happy with this. CI failures on this repo are unrelated.
21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For numpy/numpy#27044; as the version currently vendored in mesonbuild#13403 runs into. Backport the relevant patch (+fix-ups), plus a precursor that is itself not relevant to us (it's for D), but avoids having to do conflict-resolution.
This corresponds to the patches we're also currently carrying in the numpy-feedstock in conda-forge.