Uh oh!
There was an error while loading. Please reload this page.
Add nested commands - #290
Open
deemp wants to merge 14 commits into
Open
Conversation
Closed
zimbatm
commented
Jan 7, 2024
Member
Let me know when it's rebased! |
deempforce-pushed
the
add-nested-commands
branch
from
January 7, 2024 17:36
d161ef9 to
52b0eedComparedeemp
commented
Jan 7, 2024
ContributorAuthor
@zimbatm, rebased. |
deemp
commented
Jan 7, 2024
ContributorAuthor
There are some problems with types. I'll let you know when this PR is ready. |
deemp
marked this pull request as draft
January 7, 2024 18:52
deemp
marked this pull request as ready for review
January 8, 2024 00:04
deemp
commented
Jan 8, 2024
ContributorAuthor
@zimbatm, this PR is ready for a review. |
zimbatm
commented
Jan 11, 2024
Member
hmm, are you able to extract those cleanups in a separate PR? sorry the PR is a bit too large still |
ContributorAuthor
Closed
deemp
marked this pull request as draft
January 13, 2024 19:57
deempforce-pushed
the
add-nested-commands
branch
from
January 13, 2024 20:19
dbaba45 to
d45f45bComparedeemp
marked this pull request as ready for review
January 13, 2024 22:59
deempforce-pushed
the
add-nested-commands
branch
3 times, most recently
from
January 14, 2024 01:11
8e1111a to
312fae8Comparezimbatm
commented
Jan 14, 2024
Member
thanks, let me get those merged and then I'll do a deeper review here |
deempforce-pushed
the
add-nested-commands
branch
7 times, most recently
from
January 16, 2024 22:05
4ac30bc to
052ce67Comparedeempforce-pushed
the
add-nested-commands
branch
2 times, most recently
from
January 19, 2024 02:56
783d4ad to
7f9ed41Comparedeempforce-pushed
the
add-nested-commands
branch
from
January 19, 2024 03:01
7f9ed41 to
11a6066Comparedeempforce-pushed
the
add-nested-commands
branch
from
January 19, 2024 03:08
11a6066 to
2100042Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially addresses #216.
Based on #295, #297 because these PRs introduced some important changes.
commandsas an attrsetcommandsattrset (commands.<name>.*) isn't available when using TOML