Skip to content

feat: ✨ add interface for accessing ionic icons - #27

Merged
danielroe merged 11 commits into
nuxt-modules:mainfrom
Lexpeartha:icons-interface
Jul 28, 2022
Merged

feat: ✨ add interface for accessing ionic icons#27
danielroe merged 11 commits into
nuxt-modules:mainfrom
Lexpeartha:icons-interface

Conversation

@Lexpeartha

Copy link
Copy Markdown
Collaborator

Close#26

@vercel

vercelBot commented Jul 27, 2022

Copy link
Copy Markdown

Someone is attempting to deploy a commit to a Personal Account owned by @danielroe on Vercel.

@danielroe first needs to authorize it.

@vercel

vercelBot commented Jul 27, 2022

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

NameStatusPreviewUpdated
nuxt-ionic✅ Ready (Inspect)Visit PreviewJul 28, 2022 at 6:36AM (UTC)

@lgtm-com

lgtm-comBot commented Jul 27, 2022

Copy link
Copy Markdown

This pull request fixes 1 alert when merging 1fbbd7e into 04fae3e - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com

lgtm-comBot commented Jul 27, 2022

Copy link
Copy Markdown

This pull request fixes 1 alert when merging 37a6e53 into 04fae3e - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com

lgtm-comBot commented Jul 27, 2022

Copy link
Copy Markdown

This pull request fixes 1 alert when merging bcc3345 into 04fae3e - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@codecov-commenter

codecov-commenter commented Jul 28, 2022

Copy link
Copy Markdown

Codecov Report

Merging #27 (a22593c) into main (04fae3e) will increase coverage by 0.21%.
The diff coverage is 100.00%.

❗ Current head a22593c differs from pull request most recent head b3450e0. Consider uploading reports for the commit b3450e0 to get more accurate results

@@ Coverage Diff @@## main #27 +/- ##
==========================================
+ Coverage 93.53% 93.75% +0.21% 
==========================================
Files 6 7 +1 Lines 371 400 +29 Branches 33 37 +4 ==========================================
+ Hits 347 375 +28 - Misses 24 25 +1 
Impacted FilesCoverage Δ
src/module.ts96.15% <100.00%> (-0.30%)⬇️
src/parts/icons.ts100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04fae3e...b3450e0. Read the comment docs.

@lgtm-com

lgtm-comBot commented Jul 28, 2022

Copy link
Copy Markdown

This pull request fixes 1 alert when merging d726d5b into 04fae3e - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@danielroedanielroe left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a fantastic enhancement - thank you! ❤️

@danielroe
danielroe merged commit 9cd2417 into nuxt-modules:mainJul 28, 2022
@lgtm-com

lgtm-comBot commented Jul 28, 2022

Copy link
Copy Markdown

This pull request fixes 1 alert when merging b3450e0 into 04fae3e - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@Lexpeartha
Lexpeartha deleted the icons-interface branch August 3, 2022 20:34
@github-actionsgithub-actionsBot mentioned this pull request Jun 26, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: Add interface for accessing icons with Ionic

3 participants

@Lexpeartha@codecov-commenter@danielroe