Uh oh!
There was an error while loading. Please reload this page.
fix: add <div> wrapper around animation slot - #271
Merged
Conversation
✅ Deploy Preview for friendly-lamington-fb5690 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Lexpeartha
marked this pull request as ready for review
March 8, 2023 14:13
danielroe
commented
Mar 8, 2023
Collaborator
Thank you! ❤️ Do you think there's any way we can add a test for this? |
Lexpeartha
commented
Mar 9, 2023
CollaboratorAuthor
The only thing that comes to my mind as even remotely possible solution is to write e2e test that presses the button, and then after the duration of the animation it checks the styles of element. Although that may be a bit too hacky, what do you think? |
<div> wrapper around animation<div> wrapper around animation<div> wrapper around animation slotdanielroe
approved these changes
Mar 28, 2023
Collaborator
Made a couple of changes as I'm guessing that moving |
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#270
After playing around, it seems that for some reason slots can't be detected as reference elements anymore, so I had to add div wrapper for it. Not sure if this has some implications that I'm unaware of, but now it works like it used to :)