Uh oh!
There was an error while loading. Please reload this page.
feat: load app name from capacitor.config.{json,js,ts} - #469
feat: load app name from capacitor.config.{json,js,ts}#469johannschopplich wants to merge 4 commits into
capacitor.config.{json,js,ts}#469Conversation
✅ Deploy Preview for friendly-lamington-fb5690 canceled.
|
Codecov Report
@@ Coverage Diff @@## main #469 +/- ##
==========================================
- Coverage 83.36% 81.58% -1.79%
==========================================
Files 9 9 Lines 493 505 +12 Branches 30 30 ==========================================
+ Hits 411 412 +1 - Misses 82 93 +11
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| capacitor: {}, | ||
| }, | ||
| type: 'vue-vite', |
There was a problem hiding this comment.
are these changes to the written file definitely correct, bearing in mind the user might not use capacitor? And I'm not sure vue-vite is right:
To support this, we’ve introduced a new project type in the ionic.config.json, vue-vite and react-vite. These new project types will tell the CLI that it should call Vite when you run ionic serve or ionic build.
https://ionic.io/blog/ionic-cli-v7
As of right now, the app name for the to-be-generated
ionic.config.jsonis derived from the localpackage.json. This results in the followingappName:But the official Ionic configuration recommends:
I believe a better approach is to use any of the existing Capacitor configs, as it includes the to be published app name:
capacitor.config.jsoncapacitor.config.tsSince a valid
namefor apackage.jsonisn't allowed to include uppercase letters, the Capacitor config holds the more appropriate app name.