Uh oh!
There was an error while loading. Please reload this page.
docs(playground): minor clean up in the playground's tabs - #48
Merged
Conversation
Someone is attempting to deploy a commit to a Personal Account owned by @danielroe on Vercel. @danielroe first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
danielroe
approved these changes
Aug 31, 2022
danielroe
left a comment
Collaborator
There was a problem hiding this comment.
Looks good - thank you very much!
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor clean up & consistency changes to the playground's tabs.
Tab1
addionicon import as it seems to not be used in the tab<ion-toolbar>just as a clean up and I believe it's not currently in useTab2
UserPhototype for showActionSheet<ion-col>'s:keywas using the photo object directly, updated it to usephoto.filepathinsteadTab4
Aligns the title to what is being used in tabs.vue:
https://github.com/danielroe/nuxt-ionic/blob/a96309ee37bedba3ba715dfb216868ec9d015ad2/playground/pages/tabs.vue#L30