Skip to content

Fix/#568 - #570

Merged
danielroe merged 2 commits into
nuxt-modules:mainfrom
silvercent011:fix/#568
May 28, 2024
Merged

Fix/#568#570
danielroe merged 2 commits into
nuxt-modules:mainfrom
silvercent011:fix/#568

Conversation

@silvercent011

Copy link
Copy Markdown
Contributor

fixes#568

As observed in Ionic examples, user overrides need to be last in the import order. Therefore, I changed the array method from push() to unshift() to ensure that user modifications are always last. I don't know why it was working in previous versions.

Sorry for my confusing English :)

@netlify

netlifyBot commented May 28, 2024

Copy link
Copy Markdown

Deploy Preview for friendly-lamington-fb5690 canceled.

NameLink
🔨 Latest commit45a9647
🔍 Latest deploy loghttps://app.netlify.com/sites/friendly-lamington-fb5690/deploys/6655f0294646390008d8ab71

@codecov

codecovBot commented May 28, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.65%. Comparing base (4c7ff8e) to head (45a9647).

Additional details and impacted files
@@ Coverage Diff @@## main #570 +/- ##
=======================================
Coverage 46.65% 46.65% =======================================
Files 11 11 Lines 866 866 Branches 38 38 =======================================
Hits 404 404 Misses 462 462 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielroe
danielroe merged commit 5ead841 into nuxt-modules:mainMay 28, 2024
@github-actionsgithub-actionsBot mentioned this pull request Jun 26, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Custom theme variables not working - 14.0.0

2 participants

@silvercent011@danielroe