Skip to content

Typo in head.ts - #572

Merged
danielroe merged 1 commit into
nuxt-modules:mainfrom
DepkaCZ:composable-headmjs-import-typo
May 30, 2024
Merged

Typo in head.ts#572
danielroe merged 1 commit into
nuxt-modules:mainfrom
DepkaCZ:composable-headmjs-import-typo

Conversation

@DepkaCZ

Copy link
Copy Markdown
Contributor

Hi,

found a typo in head.ts composable which causes:

Pre-transform error: Failed to resolve import "#vue-router" from "node_modules/@nuxtjs/ionic/dist/runtime/composables/head.mjs?v=ccfb2c39".

#vue-router -> vue-router
@DepkaCZ
DepkaCZ requested a review from danielroe as a code ownerMay 30, 2024 14:46
@netlify

netlifyBot commented May 30, 2024

Copy link
Copy Markdown

Deploy Preview for friendly-lamington-fb5690 canceled.

NameLink
🔨 Latest commitc1c1cd6
🔍 Latest deploy loghttps://app.netlify.com/sites/friendly-lamington-fb5690/deploys/66589131ff90370008aed049

@codecov

codecovBot commented May 30, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 46.65%. Comparing base (b2bfe7e) to head (c1c1cd6).

FilesPatch %Lines
src/runtime/composables/head.ts0.00%1 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #572 +/- ##
=======================================
Coverage 46.65% 46.65% =======================================
Files 11 11 Lines 866 866 Branches 38 38 =======================================
Hits 404 404 Misses 462 462 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielroe
danielroe merged commit a6974f5 into nuxt-modules:mainMay 30, 2024
@danielroe

Copy link
Copy Markdown
Collaborator

Thank you! ❤️

@github-actionsgithub-actionsBot mentioned this pull request Jun 26, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@DepkaCZ@danielroe