Skip to content

refactor: use kit rc10 utilities - #72

Merged
danielroe merged 5 commits into
mainfrom
refactor-nuxt-rc10
Sep 20, 2022
Merged

refactor: use kit rc10 utilities#72
danielroe merged 5 commits into
mainfrom
refactor-nuxt-rc10

Conversation

@Lexpeartha

@LexpearthaLexpeartha commented Sep 20, 2022

Copy link
Copy Markdown
Collaborator

No description provided.

@LexpearthaLexpeartha added the enhancement New feature or request label Sep 20, 2022
@LexpearthaLexpeartha self-assigned this Sep 20, 2022
@vercel

vercelBot commented Sep 20, 2022•
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

NameStatusPreviewUpdated
nuxt-ionic✅ Ready (Inspect)Visit PreviewSep 20, 2022 at 1:45PM (UTC)

@codecov-commenter

codecov-commenter commented Sep 20, 2022

Copy link
Copy Markdown

Codecov Report

Merging #72 (74a7edb) into main (717f241) will increase coverage by 0.25%.
The diff coverage is 93.33%.

@@ Coverage Diff @@## main #72 +/- ##
==========================================
+ Coverage 92.79% 93.04% +0.25% 
==========================================
Files 8 8 Lines 444 446 +2 Branches 33 32 -1 ==========================================
+ Hits 412 415 +3 + Misses 32 31 -1
Impacted FilesCoverage Δ
src/parts/icons.ts40.00% <50.00%> (-5.46%)⬇️
src/module.ts96.93% <100.00%> (+0.38%)⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Lexpeartha

Lexpeartha commented Sep 20, 2022

Copy link
Copy Markdown
CollaboratorAuthor

Also, do you want me to upgrade docus in this, or another PR?

@danielroe

danielroe commented Sep 20, 2022•
edited
Loading

Copy link
Copy Markdown
Collaborator

Let's do it in another PR.

@Lexpeartha
Lexpeartha marked this pull request as ready for review September 20, 2022 13:25
@danielroe

danielroe commented Sep 20, 2022

Copy link
Copy Markdown
Collaborator

Actually, it seems that the docs are broken in this PR (not your fault!) so maybe we have to resolve at the same time.

@Lexpeartha

Lexpeartha commented Sep 20, 2022

Copy link
Copy Markdown
CollaboratorAuthor

weird, locally docs work fine for me

@Lexpeartha

Lexpeartha commented Sep 20, 2022•
edited
Loading

Copy link
Copy Markdown
CollaboratorAuthor

Just to confirm if I understood things correctly, docus in now implemented as a nuxt theme, correct?

@danielroe

danielroe commented Sep 20, 2022

Copy link
Copy Markdown
Collaborator

It is. But we might also wait until it's released.

@Lexpeartha

Lexpeartha commented Sep 20, 2022

Copy link
Copy Markdown
CollaboratorAuthor

Alright, I'll merge these changes then, and leave upgrading docus for another time

@Lexpeartha

Lexpeartha commented Sep 20, 2022

Copy link
Copy Markdown
CollaboratorAuthor

I reverted last commit, vercel build seems to be working now, no?

@danielroe

danielroe commented Sep 20, 2022

Copy link
Copy Markdown
Collaborator

Yep - sorry, didn't spot it.

@danielroedanielroe changed the title refactor: update to nuxt rc10refactor: use kit rc10 utilitiesSep 20, 2022
@danielroe
danielroe merged commit 8e64ed4 into mainSep 20, 2022
@danielroe
danielroe deleted the refactor-nuxt-rc10 branch September 20, 2022 13:58
@github-actionsgithub-actionsBot mentioned this pull request Jun 26, 2026
Draft
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danielroedanielroedanielroe approved these changes

Assignees

@LexpearthaLexpeartha

Labels

enhancementNew feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Lexpeartha@codecov-commenter@danielroe