Uh oh!
There was an error while loading. Please reload this page.
fix!: upgrade nitropack - #324
Conversation
Luferov
commented
May 11, 2022
@pi0, what about this PR? If you accept it, it will be great, please! 🙏❤️ |
dargmuesli
commented
Jun 20, 2022
Hey @danielroe, can we help somehow to get this done? |
@danielroe is also maintainer of this repo :) There is no need for my approval 👍🏼 |
Yes, this is my delay, not @pi0's! Feel free to ping me on Discord and we can chat 😉 |
cb-velmurugan
commented
Jun 29, 2022
@danielroe Is there any ETA for #32 issue because we need .html for deployment. |
This comment was marked as off-topic.
This comment was marked as off-topic.
f4e8601 to
5104137Compare
dargmuesli
left a comment
There was a problem hiding this comment.
The only difference in output for me is now - kind of obviously - that the sitemap, robots and i18n modules' outputs are missing now. Otherwise it works great!
P4sca1
commented
Jul 6, 2022
@dargmuesli Were you able to test nuxt route middleware?
|
dargmuesli
commented
Jul 6, 2022
P4sca1
commented
Jul 6, 2022
Alright, I will check the other 2 issues I currently have after the PR has been merged. |
dargmuesli
commented
Jul 6, 2022
In case anyone else wants to test this fix too for their project, here are the steps to do so in your project:
I'd be fine with a soon merge of this PR of course. I can't imagine it breaking more than what already broke? 🤭 |
@danielroe you write
Would you mind explaining the reason why that is recommended? I suppose |
pending @antfu fix
danielroe
commented
Jul 8, 2022
It's likely there are remaining issues, but I think this PR is sufficient to enable us to test and iterate with edge releases. Thank you to everyone who has tested it so far - please let me know in a new issue if you are experiencing any issues ❤️ |
@dargmuesli Without |
🔗 Linked issue
resolves#322, resolves#31, resolves#32, resolves#375, resolves#356
❓ Type of change
📚 Description
This upgrades nitropack which should fix a few issues on the books at the moment.
Also note #316 which could be combined with this one.Breaking change:
nuxi generatenow behaves differently using nitro prerendering instead of the Nuxt 2 full-static approach. If you would like to keep the Nuxt 2 generation logic while still usingnitro, you can runnuxi generate --classicor setbridge.nitroGenerator.Progress:
nuxi generateprerendering - ssr & spa👉 Migration
If you would like to keep the Nuxt 2 generation logic while still using
nitro, you can runnuxi generate --classicor setbridge.nitroGenerator.📝 Checklist