Uh oh!
There was an error while loading. Please reload this page.
feat(dev): use web fetch handler rather than proxy - #1051
Merged
Conversation
Contributor
Bundle Stats — create-nuxt size comparisonHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Contributor
Bundle Stats — nuxi size comparisonHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset (largest 100 files by percent change)
View detailed bundle breakdownAdded
Removed
Bigger
Smaller No assets were smaller Unchanged
|
Contributor
Bundle Stats — nuxt-cli size comparisonHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
commit: |
CodSpeed Performance ReportMerging #1051 will not alter performanceComparing Summary
|
danielroe
marked this pull request as ready for review
September 24, 2025 11:11
pi0
reviewed
Sep 24, 2025
Uh oh!
There was an error while loading. Please reload this page.
pi0
reviewed
Sep 24, 2025
Member
There was a problem hiding this comment.
We could port it to crossws (/node) as Nitro needs this too.
pi0
reviewed
Sep 24, 2025
| * Fetch to a specific address (socket or network) | ||
| * Based on Nitro's fetchAddress implementation | ||
| */ | ||
| function fetchAddress( |
Member
There was a problem hiding this comment.
As we have this at least 3 places now (twice in Nitro and here), this could be maintained single place upstream...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
❓ Type of change
📚 Description
this aims to fix some bugs in the current proxy implementation by dropping
httpxyand using fetch directly (as nitro does).much of the implementation is copied from nitro (thank you @pi0 - do you spot any issues here or things we can improve further?):