Skip to content

fix(dev): move clear argument default to command definition - #1054

Merged
danielroe merged 2 commits into
mainfrom
fix/dev-clear-arg-default
Sep 27, 2025
Merged

fix(dev): move clear argument default to command definition#1054
danielroe merged 2 commits into
mainfrom
fix/dev-clear-arg-default

Conversation

@BobbieGoede

@BobbieGoedeBobbieGoede commented Sep 27, 2025•
edited
Loading

Copy link
Copy Markdown
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

The default of the clear argument is effectively false (since !!undefined === false) but this default is hidden to the user. I also removed the negative description since it's kind of redundant.

@github-actions

github-actionsBot commented Sep 27, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Bundle Stats — nuxi size comparison

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files countTotal bundle size% Changed
584.5 MB → 4.5 MB (-43 B)-0.00%
Changeset
FileΔSize
src/dev/index.ts📉 -2 B (-0.05%)3.92 kB → 3.92 kB
src/commands/dev.ts📉 -41 B (-0.35%)11.33 kB → 11.29 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

AssetFile Size% Changed
chunks/dev.mjs938.2 kB → 938.16 kB (-41 B)-0.00%
chunks/index2.mjs199.56 kB → 199.56 kB (-2 B)-0.00%

Unchanged

AssetFile Size% Changed
index.mjs247 B0%
dev/index.mjs925 B0%
chunks/add.mjs6.89 kB0%
chunks/analyze.mjs3.35 kB0%
chunks/build.mjs2.07 kB0%
chunks/cleanup.mjs471 B0%
chunks/dev-child.mjs780 B0%
chunks/devtools.mjs764 B0%
chunks/generate.mjs492 B0%
chunks/info.mjs4.43 kB0%
chunks/init.mjs676.48 kB0%
chunks/index.mjs274 B0%
chunks/prepare.mjs1.05 kB0%
chunks/preview.mjs3.58 kB0%
chunks/test.mjs1.16 kB0%
chunks/typecheck.mjs2.06 kB0%
chunks/upgrade.mjs6.65 kB0%
chunks/satisfies.mjs116 B0%
chunks/main.mjs15.3 kB0%
chunks/prompt.mjs42.91 kB0%
chunks/jiti.mjs498 B0%
chunks/index3.mjs71.97 kB0%
chunks/multipart-parser.mjs5.11 kB0%
chunks/add2.mjs12.1 kB0%
chunks/search.mjs45.85 kB0%
chunks/xdg-open.mjs25.32 kB0%
chunks/node.mjs145.67 kB0%
chunks/index4.mjs1.23 kB0%
chunks/index5.mjs5.86 kB0%
chunks/index6.mjs904.13 kB0%
chunks/multipart-parser2.mjs4.58 kB0%
shared/nuxi.Bv-FePcy.mjs19.81 kB0%
shared/nuxi.DQjfoGl0.mjs57.22 kB0%
shared/nuxi.CTyTlDmo.mjs18.91 kB0%
shared/nuxi.C-cP1f7p.mjs1.71 kB0%
shared/nuxi.C_u-rG9b.mjs294 B0%
shared/nuxi.DUZ_WukQ.mjs2.57 kB0%
shared/nuxi.8mhVoXwa.mjs916.43 kB0%
shared/nuxi.D2_bzAv0.mjs1.54 kB0%
shared/nuxi.DQbQuzNE.mjs4.07 kB0%
shared/nuxi.BSm0_9Hr.mjs107 B0%
shared/nuxi.BVftAOL6.mjs18.11 kB0%
shared/nuxi.DkoVccfL.mjs10.64 kB0%
shared/nuxi.CrvQqJcE.mjs836 B0%
shared/nuxi.BiWTNJI4.mjs945 B0%
shared/nuxi.BAGoDD49.mjs1.05 kB0%
shared/nuxi.D6tXIntv.mjs158.51 kB0%
shared/nuxi.BjhZEm2-.mjs1.75 kB0%
shared/nuxi.Gg4oZG1J.mjs128.29 kB0%
shared/nuxi.QWnQy_ku.mjs5.75 kB0%
shared/nuxi.DlMb1OKt.mjs365 B0%
shared/nuxi.DU9QXUOf.mjs26.96 kB0%
shared/nuxi.8uLzFmy0.mjs14.73 kB0%
shared/nuxi.BLb4POFS.mjs42.47 kB0%
shared/nuxi.Do0aYBCO.mjs5.46 kB0%
shared/nuxi.4t9faemh.mjs43.64 kB0%

@github-actions

github-actionsBot commented Sep 27, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Bundle Stats — create-nuxt size comparison

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files countTotal bundle size% Changed
72.13 MB0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

AssetFile Size% Changed
index.mjs1.09 kB0%
chunks/multipart-parser.mjs5.11 kB0%
chunks/multipart-parser2.mjs4.58 kB0%
chunks/prompt.mjs42.91 kB0%
chunks/index.mjs904.13 kB0%
chunks/satisfies.mjs116 B0%
shared/create-nuxt.BZoiezHJ.mjs1.19 MB0%

@github-actions

github-actionsBot commented Sep 27, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Bundle Stats — nuxt-cli size comparison

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files countTotal bundle size% Changed
31103.33 kB → 103.29 kB (-43 B)-0.04%
Changeset
FileΔSize
home/runner/work/cli/cli/packages/nuxi/src/dev/index.ts📉 -2 B (-0.05%)3.89 kB → 3.89 kB
home/runner/work/cli/cli/packages/nuxi/src/commands/dev.ts📉 -41 B (-0.35%)11.29 kB → 11.25 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

AssetFile Size% Changed
chunks/dev.mjs15.86 kB → 15.82 kB (-41 B)-0.25%
chunks/index.mjs14.49 kB → 14.49 kB (-2 B)-0.01%

Unchanged

AssetFile Size% Changed
dev/index.mjs0 B0%
index.mjs236 B0%
chunks/analyze.mjs3.35 kB0%
chunks/cleanup.mjs471 B0%
chunks/dev-child.mjs815 B0%
chunks/devtools.mjs763 B0%
chunks/generate.mjs492 B0%
chunks/build.mjs2.07 kB0%
chunks/index2.mjs308 B0%
chunks/add.mjs11.25 kB0%
chunks/search.mjs2.96 kB0%
chunks/preview.mjs3.58 kB0%
chunks/test.mjs1.16 kB0%
chunks/typecheck.mjs2.06 kB0%
chunks/upgrade.mjs6.65 kB0%
chunks/prepare.mjs1.05 kB0%
chunks/info.mjs4.46 kB0%
chunks/init.mjs12.75 kB0%
chunks/add2.mjs6.89 kB0%
shared/cli.B9AmABr3.mjs39 B0%
shared/cli.CehBW0fN.mjs1.71 kB0%
shared/cli.BEUGgaW4.mjs294 B0%
shared/cli.BSm0_9Hr.mjs107 B0%
shared/cli.At9IMXtr.mjs1.23 kB0%
shared/cli.pLQ0oPGc.mjs836 B0%
shared/cli.qKvs7FJ2.mjs945 B0%
shared/cli.Cr-OCgdO.mjs727 B0%
shared/cli.DHenkA1C.mjs351 B0%
shared/cli.DVoN1ieL.mjs5.57 kB0%

@pkg-pr-new

pkg-pr-newBot commented Sep 27, 2025•
edited
Loading

Copy link
Copy Markdown

nuxt-cli-playground

npm i https://pkg.pr.new/create-nuxt@1054

npm i https://pkg.pr.new/nuxi@1054

npm i https://pkg.pr.new/@nuxt/cli@1054

commit: 5ee80ba

@codspeed-hq

codspeed-hqBot commented Sep 27, 2025•
edited
Loading

Copy link
Copy Markdown

CodSpeed Performance Report

Merging #1054 will not alter performance

Comparing fix/dev-clear-arg-default (5ee80ba) with main (9752a5b)

Summary

✅ 2 untouched

@BobbieGoedeBobbieGoede changed the title fix: move clear argument default to command definitionfix(dev): move clear argument default to command definitionSep 27, 2025
@danielroe
danielroe merged commit 9a9c2eb into mainSep 27, 2025
15 checks passed
@danielroe
danielroe deleted the fix/dev-clear-arg-default branch September 27, 2025 14:18
@github-actionsgithub-actionsBot mentioned this pull request Sep 27, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danielroedanielroeAwaiting requested review from danielroedanielroe is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@BobbieGoede@danielroe