Skip to content

fix(dev): stdin paused when using clark spinners on Windows - #1395

Merged
danielroe merged 1 commit into
nuxt:mainfrom
userquin:fix-paused-stdin-with-clark-spinners
Jul 26, 2026
Merged

fix(dev): stdin paused when using clark spinners on Windows#1395
danielroe merged 1 commit into
nuxt:mainfrom
userquin:fix-paused-stdin-with-clark-spinners

Conversation

@userquin

@userquinuserquin commented Jul 26, 2026

Copy link
Copy Markdown
Member

🔗 Linked issue

📚 Description

When using clark spinners stdin requires 2 enters, for example, pressing h + enter on Windows after installing cloudflare executable requires an additional h + enter, the stdin being paused (nuxi dev --tunnel).

@userquin
userquin requested a review from danielroe as a code ownerJuly 26, 2026 12:20

@danielroedanielroe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@pkg-pr-new

Copy link
Copy Markdown
  • nuxt-cli-playground

    npm i https://pkg.pr.new/create-nuxt@1395
    
    npm i https://pkg.pr.new/nuxi@1395
    
    npm i https://pkg.pr.new/@nuxt/cli@1395
    

commit: 244f6ea

@coderabbitai

coderabbitaiBot commented Jul 26, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

restoreRawMode() now returns early when stdin is not a TTY, resumes stdin when paused, and calls setRawMode(false) only when raw mode is enabled.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Title check✅ PassedThe title clearly summarizes the Windows stdin pause fix in dev mode.
Description check✅ PassedThe description matches the changes and explains the stdin paused issue on Windows.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@5ef1f1b). Learn more about missing BASE report.

Files with missing linesPatch %Lines
packages/nuxt-cli/src/utils/console.ts60.00%2 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #1395 +/- ##
=======================================
Coverage ? 50.27% =======================================
Files ? 81 Lines ? 3678 Branches ? 1128 =======================================
Hits ? 1849 Misses ? 1466 Partials ? 363 

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@danielroe
danielroe enabled auto-merge July 26, 2026 12:22
@codspeed-hq

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 2 untouched benchmarks


Comparing userquin:fix-paused-stdin-with-clark-spinners (244f6ea) with main (2043313)

Open in CodSpeed

@danielroe
danielroe disabled auto-merge July 26, 2026 12:36
@danielroe
danielroe merged commit ee930ed into nuxt:mainJul 26, 2026
20 of 21 checks passed
@github-actionsgithub-actionsBot mentioned this pull request Jul 26, 2026
@userquin
userquin deleted the fix-paused-stdin-with-clark-spinners branch July 26, 2026 12:46
@github-actionsgithub-actionsBot mentioned this pull request Jul 29, 2026
This was referenced Aug 24, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@userquin@codecov-commenter@danielroe