Uh oh!
There was an error while loading. Please reload this page.
refactor: report first-run and lock failures as actionable errors - #1445
Merged
Conversation
commit: |
danielroeforce-pushed
the
refactor/actionable
branch
from
August 12, 2026 12:04
4e3a770 to
3344516Compare📝 WalkthroughWalkthroughThe CLI now uses Estimated code review effort: 3 (Moderate) | ~20 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
packages/nuxt-cli/test/unit/commands/analyze.spec.ts (1)
158-162: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick winProtect the
ActionableErrortype contract in both lock-conflict tests.The current assertions pass when a generic
Errorcontains the expected message.
packages/nuxt-cli/test/unit/commands/analyze.spec.ts#L158-L162: assert that the rejection is anActionableError.packages/nuxt-cli/test/unit/commands/build.spec.ts#L128-L132: assert that the rejection is anActionableError.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/nuxt-cli/test/unit/commands/analyze.spec.ts` around lines 158 - 162, Strengthen the lock-conflict rejection assertions in packages/nuxt-cli/test/unit/commands/analyze.spec.ts lines 158-162 and packages/nuxt-cli/test/unit/commands/build.spec.ts lines 128-132 to require an ActionableError instance, not merely an error message containing “locked”; preserve the existing formatLockError assertions and lock-conflict behavior in both tests.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/nuxt-cli/src/utils/lockfile.ts`:
- Around line 335-344: Update formatLockError to distinguish an omitted
outputDir from an explicitly empty string: treat only undefined as absent, and
render an empty outputDir as "." in the writing-message path while preserving
existing non-empty paths.
---
Nitpick comments:
In `@packages/nuxt-cli/test/unit/commands/analyze.spec.ts`:
- Around line 158-162: Strengthen the lock-conflict rejection assertions in
packages/nuxt-cli/test/unit/commands/analyze.spec.ts lines 158-162 and
packages/nuxt-cli/test/unit/commands/build.spec.ts lines 128-132 to require an
ActionableError instance, not merely an error message containing “locked”;
preserve the existing formatLockError assertions and lock-conflict behavior in
both tests.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 17dc8537-bcc2-4def-95d9-4d5b405266e1
📒 Files selected for processing (17)
packages/nuxt-cli/src/commands/analyze.tspackages/nuxt-cli/src/commands/build.tspackages/nuxt-cli/src/commands/devtools.tspackages/nuxt-cli/src/commands/test.tspackages/nuxt-cli/src/dev/cert.tspackages/nuxt-cli/src/dev/listen.tspackages/nuxt-cli/src/dev/preflight.tspackages/nuxt-cli/src/dev/takeover.tspackages/nuxt-cli/src/dev/utils.tspackages/nuxt-cli/src/utils/config.tspackages/nuxt-cli/src/utils/console.tspackages/nuxt-cli/src/utils/kit.tspackages/nuxt-cli/src/utils/lockfile.tspackages/nuxt-cli/src/utils/stdout.tspackages/nuxt-cli/test/unit/commands/analyze.spec.tspackages/nuxt-cli/test/unit/commands/build.spec.tspackages/nuxt-cli/test/unit/lockfile.spec.ts
💤 Files with no reviewable changes (1)
- packages/nuxt-cli/src/utils/console.ts
Comment on lines
+335
to
+344
| export function formatLockError(info: LockInfo, options: { outputDir?: string } = {}): string { | ||
| const isWindows = process.platform === 'win32' | ||
| const killCmd = isWindows ? `taskkill /PID ${info.pid} /F` : `kill ${info.pid}` | ||
| const label = info.command === 'dev' ? 'dev server' : 'build' | ||
| const lines = [ | ||
| '', | ||
| `Another Nuxt ${label} is already running:`, | ||
| options.outputDir | ||
| ? `Another Nuxt ${label} is already writing to ${options.outputDir}:` | ||
| : `Another Nuxt ${label} is already running:`, |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Preserve output context when outputDir is empty.
If a caller passes '', this truthiness check emits the generic “already running” message. Treat undefined as the absent-value case and render an empty relative path as ..
Proposed fix
- options.outputDir- ? `Another Nuxt ${label} is already writing to ${options.outputDir}:`+ options.outputDir !== undefined+ ? `Another Nuxt ${label} is already writing to ${options.outputDir || '.'}:`📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| exportfunctionformatLockError(info: LockInfo,options: {outputDir?: string}={}): string{ | |
| constisWindows=process.platform==='win32' | |
| constkillCmd=isWindows ? `taskkill /PID ${info.pid} /F` : `kill ${info.pid}` | |
| constlabel=info.command==='dev' ? 'dev server' : 'build' | |
| constlines=[ | |
| '', | |
| `Another Nuxt ${label} is already running:`, | |
| options.outputDir | |
| ? `Another Nuxt ${label} is already writing to ${options.outputDir}:` | |
| : `Another Nuxt ${label} is already running:`, | |
| exportfunctionformatLockError(info: LockInfo,options: {outputDir?: string}={}): string{ | |
| constisWindows=process.platform==='win32' | |
| constkillCmd=isWindows ? `taskkill /PID ${info.pid} /F` : `kill ${info.pid}` | |
| constlabel=info.command==='dev' ? 'dev server' : 'build' | |
| constlines=[ | |
| '', | |
| options.outputDir!==undefined | |
| ? `Another Nuxt ${label} is already writing to ${options.outputDir||'.'}:` | |
| : `Another Nuxt ${label} is already running:`, |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@packages/nuxt-cli/src/utils/lockfile.ts` around lines 335 - 344, Update
formatLockError to distinguish an omitted outputDir from an explicitly empty
string: treat only undefined as absent, and render an empty outputDir as "." in
the writing-message path while preserving existing non-empty paths.
github-merge-queueBot
removed this pull request from the merge queue due to a conflict with the base branch
Aug 12, 2026
danielroeforce-pushed
the
refactor/actionable
branch
from
August 12, 2026 12:31
3344516 to
000e2f9Comparedanielroeforce-pushed
the
refactor/actionable
branch
from
August 12, 2026 12:52
000e2f9 to
96ee7bbCompareUh oh!
There was an error while loading. Please reload this page.
Closed
This was referenced Aug 24, 2026
Closed
Draft
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
📚 Description
this adopts the
ActionableErrorfrom #1444 to strip stacktraces from errors which don't need them, in more places