Skip to content

feat(init): Use user provided dir for package.json name field - #422

Merged
danielroe merged 4 commits into
nuxt:mainfrom
Eckhardt-D:main
Sep 24, 2025
Merged

feat(init): Use user provided dir for package.json name field#422
danielroe merged 4 commits into
nuxt:mainfrom
Eckhardt-D:main

Conversation

@Eckhardt-D

Copy link
Copy Markdown
Contributor

Closes#421

Causes some perf overhead due to 2 syscalls to read/write pkg. Can be addressed by adding source transform capabilities in giget before writing to disk.

@Deeyuude

Copy link
Copy Markdown

Great addition 🙏🏻

@Eckhardt-D

Copy link
Copy Markdown
ContributorAuthor

Great addition 🙏🏻

Haha, what could have been 😆 thanks for the flashback

@danielroe
danielroe self-requested a review as a code ownerSeptember 24, 2025 10:03
@github-actions

github-actionsBot commented Sep 24, 2025

Copy link
Copy Markdown
Contributor

Bundle Stats — nuxt-cli size comparison

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files countTotal bundle size% Changed
3197.24 kB → 97.82 kB (+588 B)+0.59%
Changeset
FileΔSize
home/runner/work/cli/cli/packages/nuxi/src/commands/init.ts📈 +588 B (+4.86%)11.81 kB → 12.39 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

AssetFile Size% Changed
chunks/init.mjs12.18 kB → 12.75 kB (+588 B)+4.71%

Smaller

No assets were smaller

Unchanged

AssetFile Size% Changed
dev/index.mjs0 B0%
index.mjs236 B0%
chunks/index.mjs14.49 kB0%
chunks/analyze.mjs3.35 kB0%
chunks/cleanup.mjs471 B0%
chunks/dev-child.mjs815 B0%
chunks/dev.mjs11.31 kB0%
chunks/devtools.mjs763 B0%
chunks/generate.mjs492 B0%
chunks/build.mjs2.04 kB0%
chunks/index2.mjs308 B0%
chunks/add.mjs11.25 kB0%
chunks/search.mjs2.96 kB0%
chunks/preview.mjs3.58 kB0%
chunks/test.mjs1.16 kB0%
chunks/typecheck.mjs2.06 kB0%
chunks/upgrade.mjs6.65 kB0%
chunks/prepare.mjs1.05 kB0%
chunks/info.mjs4.46 kB0%
chunks/add2.mjs6.89 kB0%
shared/cli.B9AmABr3.mjs39 B0%
shared/cli.Dz2be-Ai.mjs792 B0%
shared/cli.BEUGgaW4.mjs294 B0%
shared/cli.BSm0_9Hr.mjs107 B0%
shared/cli.At9IMXtr.mjs1.23 kB0%
shared/cli.pLQ0oPGc.mjs836 B0%
shared/cli.qKvs7FJ2.mjs945 B0%
shared/cli.Cr-OCgdO.mjs727 B0%
shared/cli.DHenkA1C.mjs351 B0%
shared/cli.DVoN1ieL.mjs5.57 kB0%

@github-actions

github-actionsBot commented Sep 24, 2025

Copy link
Copy Markdown
Contributor

Bundle Stats — create-nuxt size comparison

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files countTotal bundle size% Changed
72.13 MB → 2.13 MB (+588 B)+0.03%
Changeset
FileΔSize
home/runner/work/cli/cli/packages/nuxi/src/commands/init.ts📈 +588 B (+4.85%)11.85 kB → 12.42 kB
View detailed bundle breakdown

Added

AssetFile Size% Changed
shared/create-nuxt.BZoiezHJ.mjs0 B → 1.19 MB (+1.19 MB)-

Removed

AssetFile Size% Changed
shared/create-nuxt.DxHW8HtB.mjs1.19 MB → 0 B (-1.19 MB)-100%

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

AssetFile Size% Changed
index.mjs1.09 kB0%
chunks/multipart-parser.mjs5.11 kB0%
chunks/multipart-parser2.mjs4.58 kB0%
chunks/prompt.mjs42.91 kB0%
chunks/index.mjs904.13 kB0%
chunks/satisfies.mjs116 B0%

@github-actions

github-actionsBot commented Sep 24, 2025

Copy link
Copy Markdown
Contributor

Bundle Stats — nuxi size comparison

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files countTotal bundle size% Changed
583.61 MB → 3.61 MB (+588 B)+0.02%
Changeset
FileΔSize
src/commands/init.ts📈 +588 B (+4.85%)11.84 kB → 12.42 kB
View detailed bundle breakdown

Added

AssetFile Size% Changed
shared/nuxi.8uLzFmy0.mjs0 B → 14.73 kB (+14.73 kB)-
shared/nuxi.DkoVccfL.mjs0 B → 10.64 kB (+10.64 kB)-
shared/nuxi.DlMb1OKt.mjs0 B → 365 B (+365 B)-

Removed

AssetFile Size% Changed
shared/nuxi.D3mADRf9.mjs14.73 kB → 0 B (-14.73 kB)-100%
shared/nuxi.CJSnaadO.mjs10.64 kB → 0 B (-10.64 kB)-100%
shared/nuxi.BcK1uW4h.mjs365 B → 0 B (-365 B)-100%

Bigger

AssetFile Size% Changed
chunks/init.mjs675.79 kB → 676.37 kB (+588 B)+0.08%

Smaller

No assets were smaller

Unchanged

AssetFile Size% Changed
index.mjs247 B0%
dev/index.mjs925 B0%
chunks/add.mjs6.89 kB0%
chunks/analyze.mjs3.35 kB0%
chunks/build.mjs2.04 kB0%
chunks/cleanup.mjs471 B0%
chunks/dev-child.mjs780 B0%
chunks/dev.mjs28.45 kB0%
chunks/devtools.mjs764 B0%
chunks/generate.mjs492 B0%
chunks/info.mjs4.43 kB0%
chunks/index.mjs274 B0%
chunks/prepare.mjs1.05 kB0%
chunks/preview.mjs3.58 kB0%
chunks/test.mjs1.16 kB0%
chunks/typecheck.mjs2.06 kB0%
chunks/upgrade.mjs6.65 kB0%
chunks/satisfies.mjs116 B0%
chunks/main.mjs15.3 kB0%
chunks/prompt.mjs42.91 kB0%
chunks/index2.mjs199.56 kB0%
chunks/jiti.mjs498 B0%
chunks/index3.mjs71.97 kB0%
chunks/multipart-parser.mjs5.11 kB0%
chunks/add2.mjs12.1 kB0%
chunks/search.mjs45.85 kB0%
chunks/xdg-open.mjs25.32 kB0%
chunks/node.mjs145.67 kB0%
chunks/index4.mjs1.23 kB0%
chunks/index5.mjs5.85 kB0%
chunks/index6.mjs904.13 kB0%
chunks/multipart-parser2.mjs4.58 kB0%
shared/nuxi.Bv-FePcy.mjs19.81 kB0%
shared/nuxi.DQjfoGl0.mjs57.22 kB0%
shared/nuxi.CTyTlDmo.mjs18.91 kB0%
shared/nuxi.BXGZ9qFF.mjs792 B0%
shared/nuxi.C_u-rG9b.mjs294 B0%
shared/nuxi.DUZ_WukQ.mjs2.57 kB0%
shared/nuxi.8mhVoXwa.mjs916.43 kB0%
shared/nuxi.D2_bzAv0.mjs1.54 kB0%
shared/nuxi.DQbQuzNE.mjs4.07 kB0%
shared/nuxi.BSm0_9Hr.mjs107 B0%
shared/nuxi.B5WkReRs.mjs18.11 kB0%
shared/nuxi.CrvQqJcE.mjs836 B0%
shared/nuxi.BiWTNJI4.mjs945 B0%
shared/nuxi.BAGoDD49.mjs1.05 kB0%
shared/nuxi.CcH3VZ-h.mjs158.51 kB0%
shared/nuxi.BjhZEm2-.mjs1.75 kB0%
shared/nuxi.sAj5PmqJ.mjs128.28 kB0%
shared/nuxi.QWnQy_ku.mjs5.75 kB0%
shared/nuxi.DU9QXUOf.mjs26.96 kB0%
shared/nuxi.BLb4POFS.mjs42.47 kB0%
shared/nuxi.Do0aYBCO.mjs5.46 kB0%
shared/nuxi.4t9faemh.mjs43.64 kB0%

@pkg-pr-new

pkg-pr-newBot commented Sep 24, 2025

Copy link
Copy Markdown

nuxt-cli-playground

npm i https://pkg.pr.new/create-nuxt@422
npm i https://pkg.pr.new/nuxi@422
npm i https://pkg.pr.new/@nuxt/cli@422

commit: de8086f

@codecov-commenter

codecov-commenter commented Sep 24, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 21 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@46d4acf). Learn more about missing BASE report.

Files with missing linesPatch %Lines
packages/nuxi/src/commands/init.ts0.00%21 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #422 +/- ##
=======================================
Coverage ? 26.89% =======================================
Files ? 78 Lines ? 4041 Branches ? 222 =======================================
Hits ? 1087 Misses ? 2923 Partials ? 31 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codspeed-hq

codspeed-hqBot commented Sep 24, 2025

Copy link
Copy Markdown

CodSpeed Performance Report

Merging #422 will not alter performance

Comparing Eckhardt-D:main (de8086f) with main (bdc43bc)

Summary

✅ 2 untouched

@danielroedanielroe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so sorry this took so long!

@danielroe
danielroe merged commit 70b9e85 into nuxt:mainSep 24, 2025
15 checks passed
@github-actionsgithub-actionsBot mentioned this pull request Sep 24, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

use project name for package.json name in init Command

4 participants

@Eckhardt-D@Deeyuude@codecov-commenter@danielroe