ci: fix build-head size failure for forks by schirrel · Pull Request #705 · nuxt/cli

schirrel · 2025-01-26T03:07:44Z

🔗 Linked issue

Not a related issue but this state of Dan about the failure of the build-head from size for forks
#702 (comment)

❓ Type of change

📖 Documentation (updates to the documentation or readme)
🐞 Bug fix (a non-breaking change that fixes an issue)
👌 Enhancement (improving an existing functionality)
✨ New feature (a non-breaking change that adds functionality)
🧹 Chore (updates to the build process or auxiliary tools and libraries)
⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Adding repository: ${{ github.event.pull_request.head.repo.full_name }} to comparate build size for forked branchs too
From actions/checkout#551

codecov-commenter · 2025-01-26T03:08:56Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@e59a0da). Learn more about missing BASE report.

Additional details and impacted files

@@ Coverage Diff @@## main #705 +/- ##
=======================================
Coverage ? 13.36% =======================================
Files ? 68 Lines ? 3420 Branches ? 98 =======================================
Hits ? 457 Misses ? 2932 Partials ? 31

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pkg-pr-new · 2025-01-26T03:09:00Z

Open in Stackblitz

npm i https://pkg.pr.new/create-nuxt@705

npm i https://pkg.pr.new/nuxi@705

npm i https://pkg.pr.new/@nuxt/cli@705

commit: 46554b4

danielroe

thank you 🙏❤️

danielroe · 2025-01-26T04:04:02Z

oops. too hasty an approval.

still, thank you for looking at this

schirrel · 2025-01-26T04:22:26Z

THanks @danielroe , i am tring to see why the compare is failing, looks like it is relative to permisison/fork too, i am investigating that

schirrel · 2025-01-26T05:35:49Z

@danielroe i've tried one hour long all the things to find out why it was not working... even tho i was wondering if it is related to the fork, i saw some olders PR (weeks not that much) that the check passed.
Please fill free to close this one and create a branch with cherry-pick/copying the code to check if it all pass.
SOrry about that, thanks to look it up

danielroe · 2025-01-26T06:07:58Z

thank you! if you're happy to leave this PR open, I can experiment a bit with it

schirrel · 2025-01-26T07:01:12Z

@danielroe for sure, feel free to play around with it

schirrel · 2025-01-27T12:47:20Z

I did some testing and looks like when changing from pull_request to pull_request_target works, but the pull_request_target must be on the main yml.
At my test it does look like related to the fork, but quite doesnot make sense to me, once other prs with fork have passed on the past

schirrel · 2025-01-29T14:15:22Z

@danielroe sorry i wrote it wrong, by:

but the pull_request_target must be on the main yml.

i mean on the yml of the main branch here https://github.com/nuxt/cli/blob/main/.github/workflows/size.yml
at my tests, adding it on the branch/pr yml did not make any effect :/

danielroe · 2025-02-04T21:38:07Z

weirdly, this still seems to be failing.

schirrel · 2025-02-05T12:49:23Z

@danielroe i believe is due the repository: ${{ github.event.pull_request.head.repo.full_name }} line missing isnot?

schirrel · 2025-02-05T13:00:35Z

Brought back the repo info but continue to failing, nowi am changing to use sha as twk3 said in here twk3/rollup-size-compare-action#273 (comment)

schirrel · 2025-02-05T13:04:17Z

Looks like that:
for pull_request_target, it needs:

ref: ${{github.event.pull_request.head.ref}}
repository: ${{github.event.pull_request.head.repo.full_name}}

for pull_request it needs the ref to be

ref: ${{github.event.pull_request.head.sha}}

github-actions · 2025-02-05T15:22:13Z

Bundle Stats — create-nuxt-app size comparison

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
5	977.22 kB	0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
index.mjs	1.03 kB	0%
chunks/multipart-parser.mjs	5.11 kB	0%
chunks/prompt.mjs	42.92 kB	0%
chunks/satisfies.mjs	43.66 kB	0%
shared/create-nuxt-app.COz3HthK.mjs	884.5 kB	0%

github-actions · 2025-02-05T15:22:26Z

Bundle Stats — nuxi size comparison

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
52	5.66 MB	0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
index.mjs	188 B	0%
chunks/prompt.mjs	42.92 kB	0%
chunks/add.mjs	6.83 kB	0%
chunks/analyze.mjs	3.18 kB	0%
chunks/build.mjs	1.97 kB	0%
chunks/cleanup.mjs	471 B	0%
chunks/dev-child.mjs	1.94 kB	0%
chunks/dev.mjs	9.83 kB	0%
chunks/devtools.mjs	764 B	0%
chunks/generate.mjs	388 B	0%
chunks/info.mjs	4.39 kB	0%
chunks/init.mjs	796.75 kB	0%
chunks/index.mjs	274 B	0%
chunks/prepare.mjs	984 B	0%
chunks/preview.mjs	2.84 kB	0%
chunks/test.mjs	1.16 kB	0%
chunks/typecheck.mjs	1.74 kB	0%
chunks/upgrade.mjs	6.28 kB	0%
chunks/satisfies.mjs	116 B	0%
chunks/main.mjs	15.34 kB	0%
chunks/index2.mjs	928.05 kB	0%
chunks/dev2.mjs	69.63 kB	0%
chunks/index3.mjs	17.14 kB	0%
chunks/xdg-open.mjs	25.32 kB	0%
chunks/node.mjs	134.29 kB	0%
chunks/index4.mjs	1.24 kB	0%
chunks/index5.mjs	71.77 kB	0%
chunks/multipart-parser.mjs	5.11 kB	0%
chunks/add2.mjs	12.02 kB	0%
chunks/search.mjs	45.83 kB	0%
chunks/index6.mjs	5.87 kB	0%
chunks/index7.mjs	886.12 kB	0%
chunks/multipart-parser2.mjs	4.58 kB	0%
shared/nuxi.CNOaPyMI.mjs	76.09 kB	0%
shared/nuxi.CQCOwqp7.mjs	804 B	0%
shared/nuxi.OOMyZ32S.mjs	294 B	0%
shared/nuxi.DdI-vRyV.mjs	1.54 kB	0%
shared/nuxi.DA2iyhWl.mjs	17.68 kB	0%
shared/nuxi.BSm0_9Hr.mjs	107 B	0%
shared/nuxi.DdhC99SO.mjs	836 B	0%
shared/nuxi.CuJTCwFq.mjs	1.34 kB	0%
shared/nuxi.CJma5jOe.mjs	14.64 kB	0%
shared/nuxi.DJS4sf9f.mjs	6.13 kB	0%
shared/nuxi.CgvJibj-.mjs	9.65 kB	0%
shared/nuxi.DjaK5DQQ.mjs	2.02 MB	0%
shared/nuxi.E-ZsRS8r.mjs	943 B	0%
shared/nuxi.BgENdoyd.mjs	1.76 kB	0%
shared/nuxi.D-jL-mQ9.mjs	151.93 kB	0%
shared/nuxi.BhrojoaM.mjs	285.05 kB	0%
shared/nuxi.ChFrgAY-.mjs	5.71 kB	0%
shared/nuxi.Do0aYBCO.mjs	5.46 kB	0%
shared/nuxi.Dka9C7kP.mjs	43.55 kB	0%

github-actions · 2025-02-05T15:22:33Z

Bundle Stats — nuxt-cli size comparison

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
29	78.85 kB	0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
index.mjs	200 B	0%
chunks/add.mjs	6.83 kB	0%
chunks/analyze.mjs	3.18 kB	0%
chunks/build.mjs	1.97 kB	0%
chunks/cleanup.mjs	471 B	0%
chunks/dev-child.mjs	1.95 kB	0%
chunks/dev.mjs	7.21 kB	0%
chunks/devtools.mjs	763 B	0%
chunks/generate.mjs	388 B	0%
chunks/info.mjs	4.39 kB	0%
chunks/init.mjs	5.21 kB	0%
chunks/index.mjs	274 B	0%
chunks/prepare.mjs	984 B	0%
chunks/preview.mjs	2.84 kB	0%
chunks/test.mjs	1.16 kB	0%
chunks/typecheck.mjs	1.74 kB	0%
chunks/upgrade.mjs	6.28 kB	0%
chunks/dev2.mjs	7.8 kB	0%
chunks/add2.mjs	11.83 kB	0%
chunks/search.mjs	2.94 kB	0%
shared/cli.DWe7ol-H.mjs	5.48 kB	0%
shared/cli.DUZiDcEB.mjs	804 B	0%
shared/cli.D7pftKtD.mjs	294 B	0%
shared/cli.yR2Mj6Rb.mjs	1.23 kB	0%
shared/cli.BSm0_9Hr.mjs	107 B	0%
shared/cli.8etUNhu4.mjs	836 B	0%
shared/cli.DlcAx0De.mjs	1.04 kB	0%
shared/cli.DaI-EKv1.mjs	107 B	0%
shared/cli.C935N1ss.mjs	687 B	0%

danielroe · 2025-02-05T15:31:25Z

Looking, I think the issue is not about the pull_request_target but in fact the token permissions required by the action.

you can see it correctly commented above - so I'm not quite sure what is failing

schirrel · 2025-02-06T14:46:18Z

@danielroe that is real odd, i cant reason about it anymore :

schirrel · 2025-02-06T14:58:59Z

As you mentioned here #705 (comment) there was a check that passed https://github.com/nuxt/cli/actions/runs/13159970893/job/36725939692

I looked upon it and looks like the target commits are:
my fork commit 10ca2f2schirrel@10ca2f2
nuxt/cli commit 6e937396e93739

The only difference after that commit on both repos is the merge of the dependabot bf6020b 🤔 it does not make sense

danielroe · 2025-08-08T10:54:47Z

I think this was resolved in #999.

thank you for your work on this ❤️

ci: fix build-head siize failure for forks
fb88def

schirrel requested a review from danielroe as a code owner January 26, 2025 03:07

schirrel changed the title ~~ci: fix build-head siize failure for forks~~ci: fix build-head size failure for forksJan 26, 2025

schirrel force-pushed the ci/build-head-failure-for-forks branch from 577a44f to fb88defCompare January 26, 2025 03:45

danielroe approved these changes Jan 26, 2025
View reviewed changes

Merge branch 'main' into ci/build-head-failure-for-forks
ec73171

schirrel force-pushed the ci/build-head-failure-for-forks branch from 1641a70 to ec73171Compare January 26, 2025 09:47

Merge branch 'main' into ci/build-head-failure-for-forks
6a7e2d7

danielroeand others added 5 commits January 28, 2025 19:20

chore: try explicit name
a5e9780

chore: try removing permissions
f5478ea

chore: remove ref
002c060

chore: add back pull_request_target
07bee45

Merge branch 'main' into ci/build-head-failure-for-forks
febbde7

schirrel mentioned this pull request Jan 29, 2025
Error: Resource not accessible by integration twk3/rollup-size-compare-action#273
Open

schirreland others added 2 commits January 30, 2025 13:00

Merge branch 'main' into ci/build-head-failure-for-forks
8fd1e23

Merge branch 'main' into ci/build-head-failure-for-forks
c51c9fb

danielroe reviewed Feb 4, 2025
View reviewed changes

Comment thread.github/workflows/size.yml Outdated

Update .github/workflows/size.yml
e6aeac5

ci: add repository
c217f75

ci: using sha instead of ref like in rollupcomparesize example for fork
08b0eb5

schirreland others added 4 commits February 5, 2025 09:14

ci: testing conditional for ref
2aaa3c1

Merge branch 'main' into ci/build-head-failure-for-forks
bc1e789

Merge branch 'main' into ci/build-head-failure-for-forks
74d6425

Merge branch 'main' into ci/build-head-failure-for-forks
10ca2f2

Merge branch 'main' into ci/build-head-failure-for-forks
a9924ef

schirrel added 3 commits February 7, 2025 07:51

Merge branch 'main' into ci/build-head-failure-for-forks
0028062

Merge branch 'main' into ci/build-head-failure-for-forks
bcd6fcd

ci: testing using ref and repo again
46554b4

danielroe closed this Aug 8, 2025

Uh oh!

Conversation

schirrel commented Jan 26, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Linked issue

❓ Type of change

📚 Description

Uh oh!

codecov-commenter commented Jan 26, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

pkg-pr-newBot commented Jan 26, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

danielroe left a comment

Choose a reason for hiding this comment

Uh oh!

danielroe commented Jan 26, 2025

Uh oh!

schirrel commented Jan 26, 2025

Uh oh!

schirrel commented Jan 26, 2025

Uh oh!

danielroe commented Jan 26, 2025

Uh oh!

schirrel commented Jan 26, 2025

Uh oh!

schirrel commented Jan 27, 2025

Uh oh!

schirrel commented Jan 29, 2025

Uh oh!

Uh oh!

danielroe commented Feb 4, 2025

Uh oh!

schirrel commented Feb 5, 2025

Uh oh!

schirrel commented Feb 5, 2025

Uh oh!

schirrel commented Feb 5, 2025

Uh oh!

github-actionsBot commented Feb 5, 2025

Bundle Stats — create-nuxt-app size comparison

Uh oh!

github-actionsBot commented Feb 5, 2025

Bundle Stats — nuxi size comparison

Uh oh!

github-actionsBot commented Feb 5, 2025

Bundle Stats — nuxt-cli size comparison

Uh oh!

danielroe commented Feb 5, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

schirrel commented Feb 6, 2025

Uh oh!

schirrel commented Feb 6, 2025

Uh oh!

danielroe commented Aug 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

schirrel commented Jan 26, 2025•
edited
Loading

codecov-commenter commented Jan 26, 2025•
edited
Loading

pkg-pr-newBot commented Jan 26, 2025•
edited
Loading

danielroe commented Feb 5, 2025•
edited
Loading