Skip to content

fix(sort): use -1 for descending same as mongo syntax - #1176

Merged
farnabaz merged 1 commit into
mainfrom
fix/sort-order
May 30, 2022
Merged

fix(sort): use -1 for descending same as mongo syntax#1176
farnabaz merged 1 commit into
mainfrom
fix/sort-order

Conversation

@farnabaz

@farnabazfarnabaz commented May 30, 2022

Copy link
Copy Markdown
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

The idea is to match sort syntax with mongo db syntax. Mongodb uses 1 for ascending and -1 for descending sorts.
This PR will introduce a breaking change in sorting behavior. Former this content module used 0 for descending sort.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify

netlifyBot commented May 30, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt-content ready!

NameLink
🔨 Latest commit8500351
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt-content/deploys/6294b9378ab4c20009660e0a
😎 Deploy Previewhttps://deploy-preview-1176--nuxt-content.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@atinux

Copy link
Copy Markdown
Member

Let's merge quickly since few people are using sorts for now. Can we plan a patch release today or tomorrow?

@farnabaz

Copy link
Copy Markdown
MemberAuthor

There is also some bug fixes in the main branch, we will plan a release for tomorrow

@farnabaz
farnabaz merged commit 564b2e8 into mainMay 30, 2022
@farnabaz
farnabaz deleted the fix/sort-order branch May 30, 2022 14:09
@enfipy

Copy link
Copy Markdown

Guys, please update the documentation on this one. I spent an hour figuring things out 🙏

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@farnabaz@atinux@enfipy