Skip to content

fix(types): change QueryBuilderParams keys to partial - #1203

Merged
Tahul merged 2 commits into
nuxt:mainfrom
harlan-zw:fix/query-builder-param-types
Jun 3, 2022
Merged

fix(types): change QueryBuilderParams keys to partial#1203
Tahul merged 2 commits into
nuxt:mainfrom
harlan-zw:fix/query-builder-param-types

Conversation

@harlan-zw

Copy link
Copy Markdown
Contributor

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

I wanted to modify the query for a <ContentNavigation>, the docs specify you can provide a type of QueryBuilderParams. When typing a QueryBuilderParams though, it requires all fields to be provided.

I could get around this using Partial, but better to accurately represent the params, it's not guaranteed that any specific key will be available.

image

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify

netlifyBot commented Jun 3, 2022

Copy link
Copy Markdown

‼️ Deploy request for nuxt-content rejected.

NameLink
🔨 Latest commit5c9f6ca

@Tahul

Tahul commented Jun 3, 2022

Copy link
Copy Markdown
Contributor

You are totally right, I've also encountered that problem before and I'm so happy you fixed it!

Thanks a lot!

@Tahul
Tahul merged commit 32d5236 into nuxt:mainJun 3, 2022
@farnabazfarnabaz mentioned this pull request Aug 12, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@harlan-zw@Tahul