Uh oh!
There was an error while loading. Please reload this page.
fix(ContentNavigation): exception on query prop - #1205
Closed
harlan-zw wants to merge 3 commits into
Closed
Conversation
|
| Name | Link |
|---|---|
| 🔨 Latest commit | 282f24b |
atinux
commented
Jun 3, 2022
Member
Thank you! It would be nice to be able to add tests to avoid any potential regressions in the future (can be added later no pressure) |
Tahul added a commit
to harlan-zw/nuxt-content-fork
that referenced
this pull request
Jun 3, 2022
Tahul added a commit
to harlan-zw/nuxt-content-fork
that referenced
this pull request
Jun 3, 2022
Tahul
commented
Jun 3, 2022
Contributor
Hey @harlan-zw ; I applied the changes from this PR on #1206 ; as I was working on adding a test for ! 🙂 I'll be closing this one in favor of #1206, but thank you so much for this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
#1156
❓ Type of change
📚 Description
The specified type of the
queryprop isQueryBuilderParams. When you provide the query with this type an exception is thrown.The change fixes the
ContentNavigationcomponent using the prop type provided. This is the only component affected by this.Example:
This exception is thrown.
📝 Checklist