Skip to content

feat(config): allow ws config - #1249

Merged
Tahul merged 3 commits into
mainfrom
feat/ws-config
Jun 14, 2022
Merged

feat(config): allow ws config#1249
Tahul merged 3 commits into
mainfrom
feat/ws-config

Conversation

@Tahul

@TahulTahul commented Jun 13, 2022

Copy link
Copy Markdown
Contributor

🔗 Linked issue

#1244

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Resolves#1244

Allow user to change WebSocket port used, improving compatibility with Docker environments.

ws key is used for config, might be subject to changes based on @farnabaz review.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify

netlifyBot commented Jun 13, 2022•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for nuxt-content ready!

NameLink
🔨 Latest commite97622c
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt-content/deploys/62a75f245aefb2000a1f1557
😎 Deploy Previewhttps://deploy-preview-1249--nuxt-content.netlify.app/playground
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

farnabaz
farnabaz reviewed Jun 13, 2022
View reviewed changes
Comment threadsrc/module.ts Outdated
@Tahul
Tahul requested a review from farnabazJune 13, 2022 16:00
@Tahul
Tahul merged commit 6c903de into mainJun 14, 2022
@Tahul
Tahul deleted the feat/ws-config branch June 14, 2022 09:22
@farnabazfarnabaz mentioned this pull request Aug 12, 2022
Merged
farnabaz pushed a commit that referenced this pull request Sep 7, 2022
@Tahul@farnabaz
feat(config): allow ws config (#1249)
4e74723
* feat(config): allow ws config
* feat(ws): allow ws configuration from `watch` key
* chore(playground): prune playground content
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@farnabazfarnabazfarnabaz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Can specify a port of the dev ws

2 participants

@Tahul@farnabaz