Uh oh!
There was an error while loading. Please reload this page.
feat(source): allow overwriting default source - #1273
Merged
Conversation
✅ Deploy Preview for nuxt-content ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
atinux
commented
Jun 20, 2022
Member
Can we also take this opportunity to move also to the object syntax (and warn for array syntax)? |
atinux
reviewed
Jun 21, 2022
Uh oh!
There was an error while loading. Please reload this page.
atinux
reviewed
Jun 21, 2022
Uh oh!
There was an error while loading. Please reload this page.
atinux
reviewed
Jun 21, 2022
atinux
left a comment
Member
There was a problem hiding this comment.
Added few comments, overall seems good to me 👍
Co-authored-by: Sébastien Chopin <seb@nuxtjs.com>
atinux
approved these changes
Jun 21, 2022
Merged
farnabaz added a commit
that referenced
this pull request
Sep 7, 2022
* feat(source): allow overwriting default source * feat: sources object syntax * chore: update nuxt config * test: add test * docs: fix build * Apply suggestions from code review Co-authored-by: Sébastien Chopin <seb@nuxtjs.com> * fix: respect source name * chore: remove log Co-authored-by: Sébastien Chopin <seb@nuxtjs.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
resolves#1264
❓ Type of change
📚 Description
📝 Checklist