Uh oh!
There was an error while loading. Please reload this page.
fix(highlight): preload common languages - #1278
Merged
Merged
Conversation
✅ Deploy Preview for nuxt-content ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
atinux
commented
Jun 22, 2022
Member
Shall we also load ˋdiff`? |
Closed
atinux
commented
Jun 22, 2022
Member
Also, why do we have to list all preload, cannot we load it on demand? |
farnabaz
commented
Jun 22, 2022
MemberAuthor
We are dynamically import new languages but Shiki has issue with dynamic loading and it raise error. The issue reported quite while ago but still open. shikijs/shiki#257 |
atinux
approved these changes
Jun 22, 2022
js, ts and css languages Merged
farnabaz added a commit
that referenced
this pull request
Sep 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
resolves#1265
❓ Type of change
📚 Description
Treat
content.highlight.preloadand additional languages and always load'json', 'js', 'ts', 'css'.📝 Checklist