Skip to content

feat: disable document driven with route meta - #1333

Merged
atinux merged 5 commits into
mainfrom
feat/document-driven-meta
Jul 6, 2022
Merged

feat: disable document driven with route meta#1333
atinux merged 5 commits into
mainfrom
feat/document-driven-meta

Conversation

@farnabaz

Copy link
Copy Markdown
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Allow disabling/modifying document-driven

<script setup>definePageMeta({ documentDriven:false,// Or if need content but no surround documentDriven: { page:true, surround:false, },});</script>

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify

netlifyBot commented Jul 5, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt-content ready!

NameLink
🔨 Latest commit0499253
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt-content/deploys/62c57911045b530009883f98
😎 Deploy Previewhttps://deploy-preview-1333--nuxt-content.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@farnabaz
farnabaz requested review from Tahul and atinuxJuly 5, 2022 12:28
Comment threadsrc/runtime/plugins/documentDriven.ts Outdated
@atinux

Copy link
Copy Markdown
Member

Looking great thank you!

Can you update the documentation on https://content.nuxtjs.org/guide/writing/document-driven to add a "Disable or control the page data" section before the "Example" section?

farnabazand others added 2 commits July 5, 2022 17:53
Co-authored-by: Sébastien Chopin <seb@nuxtjs.com>

@hacknughacknug left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small typo

Comment threaddocs/content/3.guide/1.writing/7.document-driven.md Outdated

@TahulTahul left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙂

@atinux
atinux merged commit d5d23c9 into mainJul 6, 2022
@atinux
atinux deleted the feat/document-driven-meta branch July 6, 2022 12:24
@farnabazfarnabaz mentioned this pull request Aug 12, 2022
farnabaz added a commit that referenced this pull request Sep 7, 2022
Co-authored-by: Sébastien Chopin <seb@nuxtjs.com>
Co-authored-by: Yaël Guilloux <yael.guilloux@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@farnabaz@atinux@hacknug@Tahul