Skip to content

fix(document-driven): add empty promise for disabled features - #1356

Merged
atinux merged 1 commit into
mainfrom
fix/document-driven-promises
Jul 14, 2022
Merged

fix(document-driven): add empty promise for disabled features#1356
atinux merged 1 commit into
mainfrom
fix/document-driven-promises

Conversation

@farnabaz

Copy link
Copy Markdown
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Disabling page or navigation in document-driven will cause reducing promises length and therefore leads to invalid behavior.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@farnabaz
farnabaz marked this pull request as ready for review July 14, 2022 12:20
@netlify

netlifyBot commented Jul 14, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt-content ready!

NameLink
🔨 Latest commitda827f0
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt-content/deploys/62d009fb52992d0008e773c0
😎 Deploy Previewhttps://deploy-preview-1356--nuxt-content.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@atinux
atinux merged commit 9582f8c into mainJul 14, 2022
@atinux
atinux deleted the fix/document-driven-promises branch July 14, 2022 12:38
@farnabazfarnabaz mentioned this pull request Aug 12, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@farnabaz@atinux