Skip to content

feat: improve where query types - #1359

Merged
Tahul merged 3 commits into
mainfrom
feat/query-typed-where
Jul 19, 2022
Merged

feat: improve where query types#1359
Tahul merged 3 commits into
mainfrom
feat/query-typed-where

Conversation

@farnabaz

@farnabazfarnabaz commented Jul 18, 2022

Copy link
Copy Markdown
Member

🔗 Linked issue

resolves#1358

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Improve types of query builder. Add type for where conditions.

Screenshot 2022-07-18 at 14 46 13

Screenshot 2022-07-18 at 14 45 36

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify

netlifyBot commented Jul 18, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt-content ready!

NameLink
🔨 Latest commit0cbe00c
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt-content/deploys/62d6052245e0860008d69495
😎 Deploy Previewhttps://deploy-preview-1359--nuxt-content.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Tahul

Copy link
Copy Markdown
Contributor

This looks amazing, I love it 😍

@Tahul

Copy link
Copy Markdown
Contributor

As you are opening a PR on types, I added a small commit, it should resolve #1358

I would love to get feedback on it, as I've tried it locally with yarn link and it seemed to have improved the situation for inference with Volar, but I guess we need multiple validations on this. 😅

@farnabaz
farnabaz marked this pull request as ready for review July 19, 2022 08:49
@farnabaz

farnabaz commented Jul 19, 2022

Copy link
Copy Markdown
MemberAuthor

I can confirm that renaming files to .vue improve the typings of components.

@Tahul
Tahul merged commit 04f9dad into mainJul 19, 2022
@Tahul
Tahul deleted the feat/query-typed-where branch July 19, 2022 15:02
@farnabazfarnabaz mentioned this pull request Aug 12, 2022
farnabaz added a commit that referenced this pull request Sep 7, 2022
Co-authored-by: Yaël Guilloux <yael.guilloux@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Typescript Components other type than any

3 participants

@farnabaz@Tahul@atinux