Skip to content

fix(document-driven): Only set 404 status on SSR - #1409

Merged
atinux merged 4 commits into
mainfrom
fix/dd-404
Aug 2, 2022
Merged

fix(document-driven): Only set 404 status on SSR#1409
atinux merged 4 commits into
mainfrom
fix/dd-404

Conversation

@atinux

Copy link
Copy Markdown
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

It should not return a Nuxt error but only set the 404 status code on SSR, when using the dd mode, you can create a <DocumentDrivenNotFound /> component

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify

netlifyBot commented Aug 2, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt-content ready!

NameLink
🔨 Latest commit6a160a8
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt-content/deploys/62e94114629865000951ebfc
😎 Deploy Previewhttps://deploy-preview-1409--nuxt-content.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@atinux

Copy link
Copy Markdown
MemberAuthor

Would like a second eye for the tests @farnabaz

@atinux
atinux requested a review from farnabazAugust 2, 2022 15:07
Comment threadsrc/runtime/pages/document-driven.vue Outdated
@atinux
atinux merged commit 066c341 into mainAug 2, 2022
@atinux
atinux deleted the fix/dd-404 branch August 2, 2022 17:37
This was referenced Aug 9, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@atinux@pi0@farnabaz