Skip to content

fix: make sure components/content is on top in layers - #1418

Merged
farnabaz merged 1 commit into
nuxt:mainfrom
CodeDredd:main
Aug 8, 2022
Merged

fix: make sure components/content is on top in layers#1418
farnabaz merged 1 commit into
nuxt:mainfrom
CodeDredd:main

Conversation

@CodeDredd

Copy link
Copy Markdown
Contributor

🔗 Linked issue

closes#1417, related to nuxt/framework#6382

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

In mutli layer setups the priority of the layers is wrong and needs to be reversed, so that content is on top

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify

netlifyBot commented Aug 5, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt-content ready!

Built without sensitive environment variables

NameLink
🔨 Latest commit5c57d96
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt-content/deploys/62ed6bcf33aef200096c8feb
😎 Deploy Previewhttps://deploy-preview-1418--nuxt-content.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@atinux
atinux requested review from farnabaz and pi0August 5, 2022 23:42
@pi0

pi0 commented Aug 7, 2022

Copy link
Copy Markdown
Member

Thanks for the PR @CodeDredd <3

As you mentioned in #1417 (comment), this doesn't fully resolve the behavior to close the issue but combined with nuxt/framework#6382 it should be. And in general I think change makes sense combining unshift with reverse layer scanning.

@farnabaz
farnabaz merged commit 19bcce5 into nuxt:mainAug 8, 2022
@farnabazfarnabaz mentioned this pull request Aug 12, 2022
@pi0pi0 mentioned this pull request Aug 16, 2022
7 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot override components/content when using multi layer

3 participants

@CodeDredd@pi0@farnabaz