Skip to content

fix(<ContentRenderer>): prioritize default slot - #1460

Merged
farnabaz merged 2 commits into
mainfrom
fix/respect-default-slot
Aug 17, 2022
Merged

fix(<ContentRenderer>): prioritize default slot#1460
farnabaz merged 2 commits into
mainfrom
fix/respect-default-slot

Conversation

@farnabaz

Copy link
Copy Markdown
Member

🔗 Linked issue

resolves#1459

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Using the default slot in <ContentRenderer> did not affect rendered HTML when the content is a markdown file.
This PR will prioritize the empty slot and the default slot.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify

netlifyBot commented Aug 17, 2022

Copy link
Copy Markdown

Deploy Preview for nuxt-content ready!

NameLink
🔨 Latest commitd130849
🔍 Latest deploy loghttps://app.netlify.com/sites/nuxt-content/deploys/62fcce9e9f85a300083fc072
😎 Deploy Previewhttps://deploy-preview-1460--nuxt-content.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@farnabaz
farnabaz requested a review from atinuxAugust 17, 2022 10:58
@atinux

Copy link
Copy Markdown
Member

Would you mind adding a test case?

@farnabaz
farnabaz merged commit bf35a81 into mainAug 17, 2022
@farnabaz
farnabaz deleted the fix/respect-default-slot branch August 17, 2022 13:42
@farnabazfarnabaz mentioned this pull request Sep 2, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

<ContentRenderer> default slot problem?

2 participants

@farnabaz@atinux