Uh oh!
There was an error while loading. Please reload this page.
feat: implement csv parser with unist/mircomark stack - #1468
Merged
Conversation
✅ Deploy Preview for nuxt-content ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
farnabaz
marked this pull request as draft
August 22, 2022 15:41
farnabaz
marked this pull request as ready for review
August 23, 2022 11:42
atinux
approved these changes
Aug 25, 2022
atinux
commented
Aug 25, 2022
Member
Amazing work 🤯 |
Merged
farnabaz added a commit
that referenced
this pull request
Sep 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
resolves#1440
❓ Type of change
📚 Description
This PR attempts to replace CSV parser package with a custom parser based on unist/remark stack.
This approach will be compatible with all deploy targets and also, as of my tests the performance is better than external package
📝 Checklist